Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ENSO notebook #836

Merged
merged 7 commits into from
Apr 6, 2022
Merged

Update ENSO notebook #836

merged 7 commits into from
Apr 6, 2022

Conversation

acordonez
Copy link
Collaborator

No description provided.

@acordonez acordonez mentioned this pull request Apr 2, 2022
@lee1043
Copy link
Contributor

lee1043 commented Apr 5, 2022

@acordonez It looks like downloading is keep failing on my end, could you please check how it work on your end?

Downloading: 'misc_demo_data/fx/sftlf.GPCP-IP.1x1.nc' from 'https://pcmdiweb.llnl.gov/pss/pmpdata/' in: demo_data/misc_demo_data/fx/sftlf.GPCP-IP.1x1.nc
Download failed

@lee1043
Copy link
Contributor

lee1043 commented Apr 5, 2022

Below is what I get if I run the cdat_info.download_sample_data_files without try. @acordonez @gleckler1 any idea?

----> 5     cdat_info.download_sample_data_files("data_files.txt", demo_data_directory)
      6     print("All files downloaded")
      7 #except:

/opt/anaconda3/envs/pcmdi_metrics_dev/lib/python3.9/site-packages/cdat_info-8.2.1-py3.9.egg/cdat_info/cdat_info_src.py in download_sample_data_files(files_md5, path)
    357         n0 = 1
    358     for sample in samples[n0:]:
--> 359         good_md5, name = sample.split()
    360         local_filename = os.path.join(path, name)
    361         try:

@acordonez
Copy link
Collaborator Author

@lee1043 I'm seeing "enso_data_files.txt" instead of "data_files.txt" in my version of the notebook. Is that a change that I didn't pick up?

@acordonez
Copy link
Collaborator Author

@lee1043 @gleckler1 I checked the data_files.txt file from the Demo 0 notebook and it has an empty line at the end, which would cause a failure message.

@lee1043
Copy link
Contributor

lee1043 commented Apr 5, 2022

@acordonez I copied the error message from a different notebook (Demo 0), sorry for the confusion!

doc/jupyter/Demo/Demo_6_ENSO.ipynb Show resolved Hide resolved
@lee1043
Copy link
Contributor

lee1043 commented Apr 6, 2022

I confirmed the ENSO demo working fine. I will fix the Demo 0 issue in separate, perhaps I need to fix it from the web server.

@lee1043
Copy link
Contributor

lee1043 commented Apr 6, 2022

I think I have fixed the data_files.txt issue (empty line at the end) earlier in the web server, but it looks like somehow reverted. I will investigate on that.

@acordonez
Copy link
Collaborator Author

@lee1043 If we can't fix the issue on the server, we can do some clean up to remove blank lines after download in the Demo 0 notebook.

@lee1043 lee1043 merged commit bd96638 into main Apr 6, 2022
@lee1043 lee1043 deleted the 832_ao_enso branch April 6, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants