-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
patches: load before recompiling the elf entry block
Commit 330704a added code which applies the patches before recompiling the elf entry block, but because at that stage the patches for the current CRC were not yet loaded, effectively it did nothing. Now it actually loads the patches before applying them. As a result, it should now be possible for patches (with place=0) to be effective before the elf is executed. This is a hack, because the emulation loads the patches while it's not paused. It works, but it's not great. A better way would be to pause the emulation once the entry point is detected, then make the setting get applied normally (which also loads the patches normally), and then resume the emulation. This _should_ properly fix #627 (the test case works as expected now).
- Loading branch information
Showing
2 changed files
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevCon.WriteLn()
? Information is not really useful for the users.