Skip to content

Commit

Permalink
gsdx: add a warning on vertex trace
Browse files Browse the repository at this point in the history
Due to a division by 2, depth lsb bit is always 0

I'm not sure it is critical but let's keep a note for the future
  • Loading branch information
gregory38 committed Oct 1, 2016
1 parent d1e0729 commit 4612b79
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions plugins/GSdx/GSVertexTrace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,11 @@ void GSVertexTrace::FindMinMax(const void* vertex, const uint32* index, int coun
}
}

// FIXME/WARNING. A division by 2 is done on the depth. I suspect to avoid
// negative value. However it means that we lost the lsb bit. m_eq.z could
// be true if depth isn't constant but close enough. It also imply that
// pmin.z & 1 == 0 and pax.z & 1 == 0

#if _M_SSE >= 0x401

pmin = pmin.blend16<0x30>(pmin.srl32(1));
Expand Down

0 comments on commit 4612b79

Please sign in to comment.