Skip to content

Commit

Permalink
GSdx-Dialog: Remove useless member variable
Browse files Browse the repository at this point in the history
The adapter ID was needed to be passed before for a legacy DX9 hack which is no longer present, I figured it could cause a potential conflict when the adapter value stored at INI is outdated. (which is now a possibility after
lightning removed reference device)

The other alternative would be to just force set the INI value on dialog initialization to avoid unavailable values in the INI file, but that would be a rough for a person transitioning from debug build to release build using the reference device
option, so just removing this outdated variable for now, I rather doubt we'd be needing it in the future, in case we need adapter passing to subdialogs, the former suggestion needs to be implemented. Not implementing it right now since there's no need for it.
  • Loading branch information
ssakash committed Jun 17, 2019
1 parent cc6a58d commit 9acb871
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion plugins/GSdx/Window/GSSettingsDlg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,6 @@ bool GSShaderDlg::OnMessage(UINT message, WPARAM wParam, LPARAM lParam)

GSHacksDlg::GSHacksDlg(const std::string &adapter_id)
: GSDialog{IDD_HACKS}
, m_adapter_id(adapter_id)
, m_old_skipdraw_offset{0}
, m_old_skipdraw{0}
{
Expand Down
1 change: 0 additions & 1 deletion plugins/GSdx/Window/GSSettingsDlg.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class GSShaderDlg : public GSDialog

class GSHacksDlg : public GSDialog
{
std::string m_adapter_id;
int m_old_skipdraw_offset;
int m_old_skipdraw;

Expand Down

0 comments on commit 9acb871

Please sign in to comment.