Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gsdx-ogl: Minor adjustments to DATE code.
Don't set DATE true when Accurate Date is off, DATE is true anyway so no need to set it again. Don't call full barrier for DATE 45 at the date selection, do it at the shader call check. It's the same, plus we avoid extra checks.
- Loading branch information
1 parent
46e63c1
commit e48ce1b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Original file line | Diff line number | Diff line change |
|---|---|---|---|
|
|
@@ -1040,7 +1040,6 @@ void GSRendererOGL::DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Sour | ||
| // It is way too complex to emulate texture shuffle with DATE. So just use | // It is way too complex to emulate texture shuffle with DATE. So just use | ||
| // the slow but accurate algo | // the slow but accurate algo | ||
| GL_PERF("DATE with %s", m_texture_shuffle ? "texture shuffle" : "no prim overlap"); | GL_PERF("DATE with %s", m_texture_shuffle ? "texture shuffle" : "no prim overlap"); | ||
| DATE_GL45 = true; | DATE_GL45 = true; | ||
| DATE = false; | DATE = false; | ||
| } else if (m_om_csel.wa && !m_context->TEST.ATE) { | } else if (m_om_csel.wa && !m_context->TEST.ATE) { | ||
|
|
@@ -1060,7 +1059,6 @@ void GSRendererOGL::DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Sour | ||
| // texture barrier will split the draw call into n draw call. It is very efficient for | // texture barrier will split the draw call into n draw call. It is very efficient for | ||
| // few primitive draws. Otherwise it sucks. | // few primitive draws. Otherwise it sucks. | ||
| GL_PERF("Slower DATE with alpha %d-%d", m_vt.m_alpha.min, m_vt.m_alpha.max); | GL_PERF("Slower DATE with alpha %d-%d", m_vt.m_alpha.min, m_vt.m_alpha.max); | ||
| DATE_GL45 = true; | DATE_GL45 = true; | ||
| DATE = false; | DATE = false; | ||
| } else { | } else { | ||
|
|
@@ -1070,7 +1068,6 @@ void GSRendererOGL::DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Sour | ||
| if (GLLoader::found_GL_ARB_shader_image_load_store && GLLoader::found_GL_ARB_clear_texture) { | if (GLLoader::found_GL_ARB_shader_image_load_store && GLLoader::found_GL_ARB_clear_texture) { | ||
| DATE_GL42 = true; | DATE_GL42 = true; | ||
| } else { | } else { | ||
| DATE_GL45 = true; | DATE_GL45 = true; | ||
| DATE = false; | DATE = false; | ||
| } | } | ||
|
|
@@ -1082,7 +1079,6 @@ void GSRendererOGL::DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Sour | ||
| case ACC_DATE_NONE: | case ACC_DATE_NONE: | ||
| default: | default: | ||
| GL_PERF("Inaccurate DATE with alpha %d-%d", m_vt.m_alpha.min, m_vt.m_alpha.max); | GL_PERF("Inaccurate DATE with alpha %d-%d", m_vt.m_alpha.min, m_vt.m_alpha.max); | ||
| break; | break; | ||
| } | } | ||
| } | } | ||
|
|
@@ -1180,6 +1176,7 @@ void GSRendererOGL::DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Sour | ||
| m_ps_sel.iip = (m_vt.m_primclass == GS_SPRITE_CLASS) ? 1 : PRIM->IIP; | m_ps_sel.iip = (m_vt.m_primclass == GS_SPRITE_CLASS) ? 1 : PRIM->IIP; | ||
|
|
|
||
| if (DATE_GL45) { | if (DATE_GL45) { | ||
| m_require_full_barrier = true; | |||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
lightningterror
Author
Contributor
|
|||
| m_ps_sel.date = 5 + m_context->TEST.DATM; | m_ps_sel.date = 5 + m_context->TEST.DATM; | ||
| } else if (DATE_one) { | } else if (DATE_one) { | ||
| m_require_one_barrier = true; | m_require_one_barrier = true; | ||
|
|
|||
I'm not sure it is good idea. Maybe a future optimization could do date45 without the barrier. Mixing shader selection and barrier isn't a good thing because the barrier isn't related to shader but how we use the shader.