Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Main Window Title Bar Name Consistent with Root Folder Name #1043

Closed
escape209 opened this issue Dec 15, 2015 · 6 comments · Fixed by #1655
Closed

Keep Main Window Title Bar Name Consistent with Root Folder Name #1043

escape209 opened this issue Dec 15, 2015 · 6 comments · Fixed by #1655

Comments

@escape209
Copy link
Contributor

Currently, the name used for PCSX2's title bar is much different to the name of the root folder. This is what I mean:

Folder: pcsx2-v1.3.1-1538-gd3ec74b-windows-x86
Title: PCSX2 1.3.1-20151211085228

I would be very grateful if the name for the title bar could be changed to that of the root folder, since it's basically impossible to tell which version I'm currently using.

Something like this would be preferable - at least for me, anyway:

PCSX2 1.3.1-1538-gd3ec74b (capitalized and no OS name)

@escape209 escape209 changed the title Keep Main Window Title Bar Text Consistent with Root Folder Name Keep Main Window Title Bar Name Consistent with Root Folder Name Dec 15, 2015
@Ryudo300
Copy link
Contributor

Agreed. I actually name it exactly like you did except without the additional code at the end of it.
"PCSX2 GIT 1.3.1-1478" is what I use. (Since I have some older versions labeled as SVN)

@escape209
Copy link
Contributor Author

I'm bumping this to say that another good reason for this change is that the current title names are so long, they don't even fit in the title bar.

longtitle

Here's how short they could actually be:
shorttitle

So not only would this shorten the title significantly, but it would also allow it to be consistent with the root folder name at the same time.

The "Git" part isn't necessary, since it can be assumed that all development versions after around 1.0.0 are from Git and not SVN. It can also be assumed that all builds with the extra four digits are development versions and not stable versions.

@gregory38
Copy link
Contributor

So date is kind of useless, so I will update to add the hash version instead. However I don't know how to get builldbot internal counter (not sure it can be done)

@FlatOutPS2
Copy link
Contributor

The timestamp is useless, the date can be help, even though it's partially hidden due to the timestamp.

@gregory38
Copy link
Contributor

date of the commit ? So far I'm heading to the following

% git describe 
v1.5.0-dev-1574-g5b3dfc3

gregory38 added a commit that referenced this issue Nov 8, 2016
Shorter than date and give all the useful info

Require windows test

close #1043
@gregory38
Copy link
Contributor

Could someone test the PR #1655 Thanks you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants