Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beyond good and evil : broken graphics #1986

Open
ghost opened this issue Jun 29, 2017 · 30 comments
Open

Beyond good and evil : broken graphics #1986

ghost opened this issue Jun 29, 2017 · 30 comments

Comments

@ghost
Copy link

ghost commented Jun 29, 2017

PCSX2 version:
Last 1.5 git

PCSX2 options:
All default (Clamping and Round Mode don't do anything) , Only MTVU is enabled (bug also without).

Plugins used:
All default (GSDX)
image
image

Description of the issue:
The game Beyond good and evil have some graphical issues

1.SPS (Maj : fixed) ✔️
sps
2. DirectX hardware issues
probleme dx
3.Broken water effect (heavy performance impact)
eau
4.The shadows are broken in hardware mode
ombres
5.The software render have a bug at the bottom of the screen (Maj : fixed) ✔️
software bug
6.Cinematics pictures are missing in hardware mode
Hardware:
probleme cinematique
Software:
software cinematique

How to reproduce the issue:
Set OpenGL or DX 9/11 in GSDX and start Beyond good and evil.

Last known version to work:
Don't exist,The game was also broken on 1.4 and other versions

PC specifications:
Intel Core 2 Duo E8600 , GTX 780Ti , OS: Windows 10 64 Bit

@mirh
Copy link

mirh commented Jun 29, 2017

#1648 ?

The software render have a bug at the bottom of the screen
Acurate date cause a crash in water areas.

Those seems really concerning problems on the other hand.

Could you take a gs dump (SHIFT + F8) in those areas?

@ghost
Copy link
Author

ghost commented Jun 30, 2017

I will send them later for all issues.
Note: the Hardware hack, memory wraping don't solve these issues.

@ghost
Copy link
Author

ghost commented Jun 30, 2017

Here is the software dump : https://drive.google.com/file/d/0B0Ph0W1NYxIVZE5VaDV6WV9iRlU/view?usp=sharing For the aplication crash , i don't know how to create a crash dump sorry
Other dump arrive next.

@mirh
Copy link

mirh commented Jun 30, 2017

>Don't enable accurate date
>Take it
>... profit?

@ssakash
Copy link
Member

ssakash commented Jun 30, 2017

Sorry, software mode issue is my fault. Two things need to be addressed to fix it,

  • Calling GetFrameRect() without any parameter would result in accessing the DISPFB register context with a subscript of -1 and that would obviously screw up things, this needs to be resolved.

  • Need to also include the offsets in the frame memory height calculation as they also seem to be part of the total frame memory and the offset is only for the read output circuit. sigh (Past time me was a moron!)

output

I'll try to fix it within today, won't be sleeping before that!

EDIT: I only found out the second point after analyzing the DISPFB registers with the scissoring values. Seriously, I should read the docs more carefully.

@ghost
Copy link
Author

ghost commented Jun 30, 2017

This is the GSDump of broken hardware shadows : https://drive.google.com/file/d/0B0Ph0W1NYxIVNTQ4YmZzSlhJbjg/view?usp=sharing

@ghost
Copy link
Author

ghost commented Jun 30, 2017

@refractionpcsx2
Copy link
Member

GSDX doesn't cause SPS issues, they are core problems, usually the VU's

@ghost
Copy link
Author

ghost commented Jun 30, 2017

This is the GSDump of Water issue :
https://drive.google.com/file/d/0B0Ph0W1NYxIVZ3lHWlFsNW1pOUU/view?usp=sharing

@ghost
Copy link
Author

ghost commented Jun 30, 2017

This is the GSDump of Acurate date : https://drive.google.com/file/d/0B0Ph0W1NYxIVR194LTVkMFZ1RGs/view?usp=sharing

@gregory38
Copy link
Contributor

Did you use accurate date with accurate blending or without it?

@ghost
Copy link
Author

ghost commented Jun 30, 2017

I use blending unit accuracy at "hight" level.

@refractionpcsx2
Copy link
Member

Have you tried using supervu instead of microvu?

@ghost
Copy link
Author

ghost commented Jul 1, 2017

With Supervu or interpreter ,it's worse :
image
Note: the issue is also here in software mode.

@ssakash
Copy link
Member

ssakash commented Jul 22, 2017

The software mode exclusive bug depicted on your first post should be fixed now thanks to #1988. Thanks for reporting the issue.

Now if you excuse me, Evanesco! *poof*

@ssakash ssakash removed their assignment Jul 22, 2017
@ghost
Copy link
Author

ghost commented Oct 11, 2017

Here is the GSDX temp2 debug info + Blockdump (7zip)

https://drive.google.com/file/d/0B0Ph0W1NYxIVRkVNVVQ5U19ZSUk/view?usp=sharing

Hope get you help

@phil4853

This comment has been minimized.

@refractionpcsx2
Copy link
Member

Please make your own post for a different game please

@ghost
Copy link
Author

ghost commented Jun 3, 2018

Unfortunately there's also an SPU2x issue, some voices plays too late or stops too early.

@MrCK1
Copy link
Member

MrCK1 commented Jan 12, 2019

@atomic83GitHub Can you give us an update on this? Auto flush might fix the shadow issue (based on how it looked in the GSDump)

Also, some of the dumps can't be extracted and the blockdump runs out of data for me.

@ghost
Copy link
Author

ghost commented Jan 12, 2019

The game have less issues but is still far from perfect, now it is playable in DX11 with the new depth emulation but it have a top left screen issue in large open water areas which is missing in OpenGL.

DX11:
capture3

OpenGL
capture4

The auto flush hack doesn't solve the shadows but actually does solve an issue with water rendering (still bad but better with it on) as you can see.

Without it:
capture2

With it:
capture3

Also, there are some issues missing in the original report, some ingame sounds doesn't work properly, they are either cut-off or delayed, I tried various SPU2X options but none of them works.

There is also the sun in the intro which is consistently off even with various GSDX offset hacks.

capture

I will upload GS/blockdumps later as it's long for me at the moment.

@lightningterror
Copy link
Contributor

Which build did you test ?

@ghost
Copy link
Author

ghost commented Jan 12, 2019

1.5 Build 2760, I will test on a more recent build.

@lightningterror
Copy link
Contributor

Yes too old, test recent.

@ghost
Copy link
Author

ghost commented Jan 12, 2019

It's the same with the latest build.

@kakardo
Copy link

kakardo commented Feb 13, 2022

2022 02 13_03 00 02_pcsx2
2022 02 13_03 01 51_pcsx2

Hello! Is there a fix nowadays for the broken water graphics? I'm using version 1.6.0

@RedDevilus
Copy link
Contributor

Open issues suggests there are no fixes or workarounds possible.

@kakardo
Copy link

kakardo commented Feb 13, 2022

Open issues suggests there are no fixes or workarounds possible.

Damn... I just learned to use the wiki and found that the issue is documented as "broken water rendering". I hope someone smart finds a way to fix it in the future.

@RedDevilus
Copy link
Contributor

Yeah unfortunately it's a partial fix and probably all the easily hanged-fruit are already resolved in general. Though I may yet once again be pleasantly surprised by contributors.

@refractionpcsx2
Copy link
Member

@kakardo enabling the Auto Flush HW Hack will improve things, but yeah, it's broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants