Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Detect shuffles using quads #11146

Merged
merged 1 commit into from Apr 28, 2024
Merged

GS/HW: Detect shuffles using quads #11146

merged 1 commit into from Apr 28, 2024

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Apr 25, 2024

Description of Changes

Detect triangle quads used for shuffles.

Rationale behind Changes

We only checked for sprites before, so this fixes that. We do still treat it like sprites when processing further on, but it doesn't seem to matter, so YOLO.

Suggested Testing Steps

Test Toyko Xtreme Racer Drift 2, nothing else showed in dump run.

Fixes #8203

Hard to see as it's a fade, but this is Toyko Xtreme Racer Drift 2
Master:
Tokyo_Xtreme_Racer_Drift_2_SLUS-21394_20230217234730_frame3
PR:
Tokyo_Xtreme_Racer_Drift_2_SLUS-21394_20230217234730_frame3

@GitHub-Khi
Copy link

WWE SmackDown! vs. Raw 2006 and WWE SmackDown! vs. Raw 2007 seem to have these broken shuffle problems as well, or am i thinking in the wrong direction? (One of the several issues from #3636)

Hollywood Hulk Hogan Entrance & Matrix Effect Finisher:
WWE SmackDown! vs. Raw 2006_SLUS-21286_20240427105631.zip
WWE SmackDown! vs. Raw 2006_SLUS-21286_20240427105737.zip

Hollywood Hulk Hogan Entrance:
WWE SmackDown! vs. Raw 2007_SLUS-21427_20240427110033.zip

@JordanTheToaster
Copy link
Contributor

WWE SmackDown! vs. Raw 2006 and WWE SmackDown! vs. Raw 2007 seem to have these broken shuffle problems as well, or am i thinking in the wrong direction? (One of the several issues from #3636)

Hollywood Hulk Hogan Entrance & Matrix Effect Finisher: WWE SmackDown! vs. Raw 2006_SLUS-21286_20240427105631.zip WWE SmackDown! vs. Raw 2006_SLUS-21286_20240427105737.zip

Hollywood Hulk Hogan Entrance: WWE SmackDown! vs. Raw 2007_SLUS-21427_20240427110033.zip

Unrelated to this.

@GitHub-Khi
Copy link

I see. I just thought because the current problems in these games looks pretty similar.

@refractionpcsx2
Copy link
Member Author

I'm looking in to those now, they are shuffle problems, but a different one, which gets broken by an old hack. I'm making sure removing the old hack doesn't regress anything, I'll PR that separately.

@refractionpcsx2 refractionpcsx2 merged commit f5276f1 into master Apr 28, 2024
22 checks passed
@refractionpcsx2 refractionpcsx2 deleted the gs_trishuffle branch April 28, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Glitchy cutscene screen in tokyo xrteme racer drift 2
5 participants