GS/HW: Remove shuffle misdetection hack #11153
Conversation
|
Smackdown vs Raw 2006 black and white entrances (e.g. Hollywood Hulk Hogan) have been fixed by this. |
|
That was really quick! The only thing left to test in WWE SmackDown! vs. Raw 2006 is the slow-mo effect of the finishers, right? :) |
Also half fixed just like up top |
|
is that also svr 2006? We need to know all the game names so Jordan can add them for full fixes (GS dumps would also be cool) |
Yeah that's from SvR 2006, I don't know about 2007 though. Sure no probs |
|
My GS dumps from #11146 are actually all the necessary GS dumps. Yes, the finishers thing is only in '06 and in '07 as in '06, there is the Hollywood Hulk Hogan entrance problem. :) |
Description of Changes
Removes an old hack from when texture shuffle detection was worse.
Rationale behind Changes
It was actually breaking shuffles in WWE where it shuffles RG -> BA in one sprite, this code was panicking and disabling it.
Suggested Testing Steps
Test the following games (and the WWE ones mentioned in #3636 ) dump run is fine.
To test:
Devil May Cry 3 (not sure, some shuffle effect, so make sure it looks right, shadows work etc)
Okami (generally make sure it works ok)
Onimusha 3 (not sure, some shuffle effect, possibly post effect, though I think we fixed this previously)
Shadow of Memories/Destiny (shadows)
Tomb Raider - Angel of Darkness (Fog effect)
This is one of the last problems from #3636
WWE Smackdown Vs Raw 2007 (This is fully fixed with Tex in RT, which is coming in a future PR)
Master:
PR;