Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCSX2-GUI: Revision of tooltips/descriptions and other fixes for PCSX2 (Lilypad + others) #3457

Merged
merged 6 commits into from Sep 10, 2020
Merged

Conversation

RedDevilus
Copy link
Contributor

@RedDevilus RedDevilus commented Jun 13, 2020

Changes to Large Framebuffer, 8-bit textures, Xinput, Dinput, huge chunk of memory cards section, Framelimiter, Zoom.
Recording and Recording to Input Recording and Screenrecorder.
Miscellaneous improvements to DPI scaling or small revisions (adding or rehauling strings).
And more...

GUI clean-up and change the tooltips and descriptions to be more easy to understand to endusers.
Todo:

  • Tooltip/description changes
  • Error-checking 100% done

@RedDevilus
Copy link
Contributor Author

RedDevilus commented Jun 13, 2020

The new default
image

@RedDevilus
Copy link
Contributor Author

So how do people feel about this? I know this will help certain controllers like the DS4 and others, but on the other side of this discussion some controllers only have Dinput capabilities.

@lightningterror
Copy link
Contributor

Not really in favor since there are plenty of Dinput controllers as well.

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Jul 29, 2020

Nor am I. There's no harm in DInput being enabled.

I'd be more in favour of you changing the description to say

DirectInput (Disable if you have a DS4 controller)

@RedDevilus
Copy link
Contributor Author

RedDevilus commented Jul 29, 2020

That's fair, perhaps the detection system could be different like when dinput and xinput are available it autopicks, or revise tooltips.
Most times its DS4 which have problems but there are others, wouldn't be improvement to a pretty huge userbase of dinput users.
I can change this PR or make a new one.

@refractionpcsx2
Copy link
Member

Some sort of auto detection would be nice if you can do that. You can update this one if you like, just make sure you edit the title/description

@lightningterror
Copy link
Contributor

You can edit this one.

@RedDevilus
Copy link
Contributor Author

RedDevilus commented Jul 29, 2020

I'll try looking into it, hopefully i am able to do that. Perhaps extrapolate extra types of controllers who have the same problem and assign them the right type. I think it was Switch controller and some others if i remember correctly. Atleast we know DS4 has a pretty high chance to go wrong with Dinput enabled.

@RedDevilus RedDevilus marked this pull request as draft July 29, 2020 23:48
@RedDevilus RedDevilus changed the title Disables Dinput by default Revision of tooltips/description Lilypad (+ others) Jul 30, 2020
@RedDevilus
Copy link
Contributor Author

Seems autodetecting DS4 and changing the case of Dinput to off is out of my scope of expertise. I'll atleast change descriptions/tooltips on the GUI (like the plugins).

plugins/GSdx/Window/GSSetting.cpp Outdated Show resolved Hide resolved
plugins/GSdx/Window/GSSetting.cpp Outdated Show resolved Hide resolved
plugins/LilyPad/Tooltips.cpp Outdated Show resolved Hide resolved
plugins/LilyPad/Tooltips.cpp Show resolved Hide resolved
@RedDevilus
Copy link
Contributor Author

I've rebased and reduced some commits, i'll take some time to do changes that helps people instead of making it worse or harder to understand.

@lightningterror lightningterror self-assigned this Aug 1, 2020
@RedDevilus RedDevilus changed the title Revision of tooltips/description Lilypad (+ others) PCSX2:GUI Revision of tooltips/description Lilypad (+ others) Aug 19, 2020
@RedDevilus
Copy link
Contributor Author

RedDevilus commented Aug 19, 2020

Some examples;
Memory cards:
image

LilyPad:
image

Emulation settings:
image
image

I basically reworded sentences/ removed experimental mentions for folders (i have been using them for years now without trouble). I still have to do the others and perhaps revise them.

@RedDevilus
Copy link
Contributor Author

This will change translatable strings while being more accessible and user-friendly for reading.

@RedDevilus RedDevilus changed the title PCSX2:GUI Revision of tooltips/description Lilypad (+ others) PCSX2-GUI Revision of tooltips/descriptions for Lilypad and others Aug 21, 2020
@RedDevilus RedDevilus changed the title PCSX2-GUI Revision of tooltips/descriptions for Lilypad and others PCSX2-GUI: Revision of tooltips/descriptions for Lilypad and others Aug 21, 2020
@lightningterror
Copy link
Contributor

Commits can be better named with prefixes
example
pcsx2-gui: Update Lilypad descriptions/tooltips. to Lilypad-gui: Update descriptions/tooltips.

@RedDevilus
Copy link
Contributor Author

Changed input recording to input recording because of DPI on 100% maligns it
image

Capture:
image

and many other minor changes

else
return _("[-- No unused cards --]");
return _("[-- No disabled cards --]");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't unused seem better?

Copy link
Contributor Author

@RedDevilus RedDevilus Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just make it into No Cards, No unused or even no disabled looks confusing. If you delete all memory cards then it will say the same which makes it technically wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will also solve the problem of DPI scaling i am having, but it is fine on 100%.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

↓↓ No cards ↓↓ could also be an alternative

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples:
image

image

Also avoids a double negative.

Copy link
Contributor Author

@RedDevilus RedDevilus Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it back to avoid unicode problem (arrows)

@xTVaser
Copy link
Sponsor Member

xTVaser commented Sep 5, 2020

Input Recording name change portion is fine by me. We'll do a pass to make sure internal naming is updated once things die down a bit. 👍

Copy link
Sponsor Contributor

@RedPanda4552 RedPanda4552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a healthy number of comments to make but still overall would approve merging as is. Would like to see some changes but either way is fine.

pcsx2/gui/Dialogs/ConvertMemoryCardDialog.cpp Outdated Show resolved Hide resolved
pcsx2/gui/Dialogs/CreateMemoryCardDialog.cpp Outdated Show resolved Hide resolved
pcsx2/gui/Dialogs/CreateMemoryCardDialog.cpp Outdated Show resolved Hide resolved
pcsx2/gui/Dialogs/CreateMemoryCardDialog.cpp Outdated Show resolved Hide resolved
pcsx2/gui/Dialogs/McdConfigDialog.cpp Outdated Show resolved Hide resolved
plugins/GSdx/Window/GSSetting.cpp Outdated Show resolved Hide resolved
plugins/LilyPad/LilyPad.rc Show resolved Hide resolved
plugins/LilyPad/Tooltips.cpp Outdated Show resolved Hide resolved
plugins/LilyPad/Tooltips.cpp Outdated Show resolved Hide resolved
plugins/LilyPad/Tooltips.cpp Outdated Show resolved Hide resolved
@RedDevilus
Copy link
Contributor Author

I haven't added more changes to the PR for delay hell and to accelerate other PRs.

DS4 is finicky sometimes with Directinput enabled and is best used with Xinput + Steam (Steam is recommended for all controllers).
Alternative for DS4 is Ryochan7/DS4Windows (not main DS4Windows).
Large framebuffer should only be used in cases of stuttery FMVs (cutscenes). 4/8 bits is best used where GPU is much stronger than CPU.
Fix DPI scaling for OSD color sliders (FPS + other stats).
FMV Aspect Ratio Override = Off is the same as the value for Aspect Ratio. Formatting fix for Zoom tooltip.
Double click on emulation windows also does fullscreen. Disable framelimiting means Uncapping the FPS.
Capped slowmotion adjust at 5% (it doesn't accept lower than 5 anyway). MTGS gets debug tag (useless for many).
Auto-Eject checkbox is a failsave for broken saves. Card (file)name to Memory Card (like a real PS2 you need to plug a memory card in port 1 to work).
Add usable to formatted to be obvious if you can use the memory card. Changed default column width.
Change 2 recordings (CaptureVideo and Recordings) to Screenrecorder and Input Recording.
Add Input to recording. Lowercase to uppercase words.
@lightningterror lightningterror merged commit 043832a into PCSX2:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants