New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCSX2-GUI: Revision of tooltips/descriptions and other fixes for PCSX2 (Lilypad + others) #3457
Conversation
So how do people feel about this? I know this will help certain controllers like the DS4 and others, but on the other side of this discussion some controllers only have Dinput capabilities. |
Not really in favor since there are plenty of Dinput controllers as well. |
Nor am I. There's no harm in DInput being enabled. I'd be more in favour of you changing the description to say DirectInput (Disable if you have a DS4 controller) |
That's fair, perhaps the detection system could be different like when dinput and xinput are available it autopicks, or revise tooltips. |
Some sort of auto detection would be nice if you can do that. You can update this one if you like, just make sure you edit the title/description |
You can edit this one. |
I'll try looking into it, hopefully i am able to do that. Perhaps extrapolate extra types of controllers who have the same problem and assign them the right type. I think it was Switch controller and some others if i remember correctly. Atleast we know DS4 has a pretty high chance to go wrong with Dinput enabled. |
Seems autodetecting DS4 and changing the case of Dinput to off is out of my scope of expertise. I'll atleast change descriptions/tooltips on the GUI (like the plugins). |
I've rebased and reduced some commits, i'll take some time to do changes that helps people instead of making it worse or harder to understand. |
This will change translatable strings while being more accessible and user-friendly for reading. |
Commits can be better named with prefixes |
else | ||
return _("[-- No unused cards --]"); | ||
return _("[-- No disabled cards --]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't unused seem better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just make it into No Cards, No unused or even no disabled looks confusing. If you delete all memory cards then it will say the same which makes it technically wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will also solve the problem of DPI scaling i am having, but it is fine on 100%.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
↓↓ No cards ↓↓ could also be an alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it back to avoid unicode problem (arrows)
Input Recording name change portion is fine by me. We'll do a pass to make sure internal naming is updated once things die down a bit. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a healthy number of comments to make but still overall would approve merging as is. Would like to see some changes but either way is fine.
I haven't added more changes to the PR for delay hell and to accelerate other PRs. |
DS4 is finicky sometimes with Directinput enabled and is best used with Xinput + Steam (Steam is recommended for all controllers). Alternative for DS4 is Ryochan7/DS4Windows (not main DS4Windows).
Large framebuffer should only be used in cases of stuttery FMVs (cutscenes). 4/8 bits is best used where GPU is much stronger than CPU. Fix DPI scaling for OSD color sliders (FPS + other stats).
FMV Aspect Ratio Override = Off is the same as the value for Aspect Ratio. Formatting fix for Zoom tooltip. Double click on emulation windows also does fullscreen. Disable framelimiting means Uncapping the FPS. Capped slowmotion adjust at 5% (it doesn't accept lower than 5 anyway). MTGS gets debug tag (useless for many).
Auto-Eject checkbox is a failsave for broken saves. Card (file)name to Memory Card (like a real PS2 you need to plug a memory card in port 1 to work). Add usable to formatted to be obvious if you can use the memory card. Changed default column width.
Change 2 recordings (CaptureVideo and Recordings) to Screenrecorder and Input Recording.
Add Input to recording. Lowercase to uppercase words.
Changes to Large Framebuffer, 8-bit textures, Xinput, Dinput, huge chunk of memory cards section, Framelimiter, Zoom.
Recording and Recording to Input Recording and Screenrecorder.
Miscellaneous improvements to DPI scaling or small revisions (adding or rehauling strings).
And more...
GUI clean-up and change the tooltips and descriptions to be more easy to understand to endusers.
Todo: