Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCSX2-GUI: Revision of tooltips/descriptions and other fixes for PCSX2 (Lilypad + others) #3457

Merged
merged 6 commits into from
Sep 10, 2020
Merged

PCSX2-GUI: Revision of tooltips/descriptions and other fixes for PCSX2 (Lilypad + others) #3457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d70e065
Lilypad-gui: Update descriptions/tooltips.(PR3457)
RedDevilus Jul 30, 2020
1e3266c
GSdx-gui: Update descriptions/tooltips.
RedDevilus Jul 30, 2020
5b1d55a
EmulationSettings-gui: Update descriptions/tooltips.
RedDevilus Aug 19, 2020
5a363d5
MemoryCards-gui: Update descriptions/tooltips.
RedDevilus Aug 19, 2020
14dc602
pcsx2-gui: Update main window description/tooltips.
RedDevilus Aug 31, 2020
035e92d
Console-gui: Update descriptions.
RedDevilus Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pcsx2/SourceLog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ TLD_sysoutConsole = {

#ifndef DISABLE_RECORDING
,TLD_recordingConsole = {
L"Recording", L"Recording Console",
L"Input Recording", L"Input Recording Console",
pxDt("Shows recording related logs and information")
},

Expand Down
6 changes: 3 additions & 3 deletions pcsx2/gui/App.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ enum TopLevelMenuIndices
TopLevelMenu_Window,
TopLevelMenu_Capture,
#ifndef DISABLE_RECORDING
TopLevelMenu_Recording,
TopLevelMenu_InputRecording,
#endif
TopLevelMenu_Help
};
Expand Down Expand Up @@ -121,7 +121,7 @@ enum MenuIdentifiers
MenuId_EnablePatches,
MenuId_EnableCheats,
MenuId_EnableWideScreenPatches,
MenuId_EnableRecordingTools,
MenuId_EnableInputRecording,
MenuId_EnableLuaTools,
MenuId_EnableHostFs,

Expand Down Expand Up @@ -194,7 +194,7 @@ enum MenuIdentifiers
MenuId_Capture_Screenshot,

#ifndef DISABLE_RECORDING
// Recording Subsection
// Input Recording Subsection
MenuId_Recording_New,
MenuId_Recording_Play,
MenuId_Recording_Stop,
Expand Down
10 changes: 5 additions & 5 deletions pcsx2/gui/ConsoleLogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,16 +418,16 @@ ConsoleLogFrame::ConsoleLogFrame( MainEmuFrame *parent, const wxString& title, A

menuFontSizes.Append( MenuId_FontSize_Small, _("&Small"), _t("Fits a lot of log in a microcosmically small area."),
wxITEM_RADIO )->Check( options.FontSize == 7 );
menuFontSizes.Append( MenuId_FontSize_Normal, _("&Normal font"),_t("It's what I use (the programmer guy)."),
menuFontSizes.Append( MenuId_FontSize_Normal, _("&Normal Font"),_t("It's what I use (the programmer guy)."),
wxITEM_RADIO )->Check( options.FontSize == 8 );
menuFontSizes.Append( MenuId_FontSize_Large, _("&Large"), _t("Its nice and readable."),
wxITEM_RADIO )->Check( options.FontSize == 10 );
menuFontSizes.Append( MenuId_FontSize_Huge, _("&Huge"), _t("In case you have a really high res display."),
wxITEM_RADIO )->Check( options.FontSize == 12 );

menuFontSizes.AppendSeparator();
menuFontSizes.Append( MenuId_ColorScheme_Light, _("&Light theme"), _t("Default soft-tone color scheme."), wxITEM_RADIO );
menuFontSizes.Append( MenuId_ColorScheme_Dark, _("&Dark theme"), _t("Modern dark color scheme."), wxITEM_RADIO );
menuFontSizes.Append( MenuId_ColorScheme_Light, _("&Light Theme"), _t("Default soft-tone color scheme."), wxITEM_RADIO );
menuFontSizes.Append( MenuId_ColorScheme_Dark, _("&Dark Theme"), _t("Modern dark color scheme."), wxITEM_RADIO );

// The "Always on Top" option currently doesn't work
//menuAppear.AppendSeparator();
Expand Down Expand Up @@ -465,8 +465,8 @@ ConsoleLogFrame::ConsoleLogFrame( MainEmuFrame *parent, const wxString& title, A
}

menuSources.AppendSeparator();
menuSources.Append( MenuId_LogSource_EnableAll, _("&Enable all"), _("Enables all log source filters.") );
menuSources.Append( MenuId_LogSource_DisableAll, _("&Disable all"), _("Disables all log source filters.") );
menuSources.Append( MenuId_LogSource_EnableAll, _("&Enable All"), _("Enables all log source filters.") );
menuSources.Append( MenuId_LogSource_DisableAll, _("&Disable All"), _("Disables all log source filters.") );
menuSources.Append( MenuId_LogSource_SetDefault, _("&Restore Default"), _("Restore default source filters.") );

pMenuBar->Append(&menuLog, _("&Log"));
Expand Down
13 changes: 8 additions & 5 deletions pcsx2/gui/Dialogs/ConvertMemoryCardDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,18 @@ Dialogs::ConvertMemoryCardDialog::ConvertMemoryCardDialog( wxWindow* parent, con
void Dialogs::ConvertMemoryCardDialog::CreateControls( const MemoryCardType sourceType ) {
m_text_filenameInput = new wxTextCtrl( this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, wxTE_PROCESS_ENTER );

RadioPanelItem toFile8MB = RadioPanelItem( _( "8MB File" ), pxE( L"Convert this memory card to a standard 8 MB Memory Card .ps2 file." ) )
RadioPanelItem toFile8MB = RadioPanelItem( _( "8 MB File (most compatible)" ), pxE( L"Convert this memory card to a standard 8 MB Memory Card .ps2 file." ) )
.SetInt( MemoryCardConversionType::MemoryCardConversion_File_8MB );
RadioPanelItem toFile16MB = RadioPanelItem( _( "16MB File" ), pxE( L"Convert this memory card to a 16 MB Memory Card .ps2 file." ) )
RadioPanelItem toFile16MB = RadioPanelItem( _( "16 MB File" ), pxE( L"Convert this memory card to a 16 MB Memory Card .ps2 file." ) )
.SetInt( MemoryCardConversionType::MemoryCardConversion_File_16MB );
RadioPanelItem toFile32MB = RadioPanelItem( _( "32MB File" ), pxE( L"Convert this memory card to a 32 MB Memory Card .ps2 file." ) )
RadioPanelItem toFile32MB = RadioPanelItem( _( "32 MB File" ), pxE( L"Convert this memory card to a 32 MB Memory Card .ps2 file." ) )
.SetInt( MemoryCardConversionType::MemoryCardConversion_File_32MB );
RadioPanelItem toFile64MB = RadioPanelItem( _( "64MB File" ), pxE( L"Convert this memory card to a 64 MB Memory Card .ps2 file." ) )
RadioPanelItem toFile64MB = RadioPanelItem( _( "64 MB File" ), pxE( L"Convert this memory card to a 64 MB Memory Card .ps2 file." ) )
.SetInt( MemoryCardConversionType::MemoryCardConversion_File_64MB );
RadioPanelItem toFolder = RadioPanelItem( _( "Folder" ), _( "Convert this memory card to a folder of individual saves." ) )
RadioPanelItem toFolder = RadioPanelItem( _( "Folder" ), _(
"Convert this memory card to a folder of individual saves. "
"Unlimited capacity for saving and is not compatible with other PS2 emulators. "
"Allows direct access to the saves which makes it easy to view and back-up per game." ) )
.SetInt( MemoryCardConversionType::MemoryCardConversion_Folder );

const RadioPanelItem tblForFile[] = { toFolder };
Expand Down
9 changes: 7 additions & 2 deletions pcsx2/gui/Dialogs/CreateMemoryCardDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,13 @@ void Dialogs::CreateMemoryCardDialog::CreateControls()
. SetToolTip(_t("Use at your own risk. Erratic memory card behavior is possible (though unlikely)."))
. SetInt(64),

RadioPanelItem(_("Folder [experimental]"), _("Store memory card contents in the host filesystem instead of a file."))
. SetToolTip(_t("Automatically manages memory card contents so that the console only sees files related to the currently running software. Allows you to drag-and-drop files in and out of the memory card with your standard file explorer. This is still experimental, so use at your own risk!"))
RadioPanelItem(_("Folder [Recommended]"), _("Store memory card contents in the host filesystem instead of a file."))
. SetToolTip(_t("Dynamically allocate and store memory card contents in a folder.\n"
"Only exposes the save files for the running game, rather than the whole memory card.\n"
"You can see the structure and the saves with your File Explorer.\n"
"Can be used to back-up individual saves instead of all saves on a memcard.\n"
"Incompatible with PS2 memory card editing tools or savegame managers (such as MyMC, MyMCPlus).\n"
"You can always convert back between folder type and single memcard file.\n"))
. SetInt(0),

RadioPanelItem(_("128 KiB (PSX)"), _("This is the standard Sony-provisioned size PSX memory card, only compatible with PSX games."))
Expand Down
4 changes: 2 additions & 2 deletions pcsx2/gui/Dialogs/McdConfigDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ Panels::McdConfigPanel_Toggles::McdConfigPanel_Toggles(wxWindow *parent)
{
m_check_Ejection = new pxCheckBox( this,
_("Auto-eject memory cards when loading savestates"),
pxE( L"Avoids memory card corruption by forcing games to re-index card contents after loading from savestates. May not be compatible with all games (Guitar Hero)."
pxE( L"Avoids broken memory card saves. May not work with some games such as Guitar Hero."
)
);

m_folderAutoIndex = new pxCheckBox( this,
_( "Automatically manage saves based on running game" ),
pxE( L"(Folder type only) Re-index memory card content every time the running software changes. This prevents the memory card from running out of space for saves."
pxE( L"(Folder type only / Card size: Auto) Loads only the relevant booted game saves, ignoring others. Avoids running out of space for saves."
)
);

Expand Down
20 changes: 10 additions & 10 deletions pcsx2/gui/MainFrame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ void MainEmuFrame::ConnectMenus()
Bind(wxEVT_MENU, &MainEmuFrame::Menu_EnableCheats_Click, this, MenuId_EnableCheats);
Bind(wxEVT_MENU, &MainEmuFrame::Menu_EnableWideScreenPatches_Click, this, MenuId_EnableWideScreenPatches);
#ifndef DISABLE_RECORDING
Bind(wxEVT_MENU, &MainEmuFrame::Menu_EnableRecordingTools_Click, this, MenuId_EnableRecordingTools);
Bind(wxEVT_MENU, &MainEmuFrame::Menu_EnableRecordingTools_Click, this, MenuId_EnableInputRecording);
#endif
Bind(wxEVT_MENU, &MainEmuFrame::Menu_EnableHostFs_Click, this, MenuId_EnableHostFs);
Bind(wxEVT_MENU, &MainEmuFrame::Menu_SysShutdown_Click, this, MenuId_Sys_Shutdown);
Expand Down Expand Up @@ -373,7 +373,7 @@ void MainEmuFrame::CreatePcsx2Menu()
_("Enabling Widescreen Patches may occasionally cause issues."), wxITEM_CHECK);

#ifndef DISABLE_RECORDING
m_GameSettingsSubmenu.Append(MenuId_EnableRecordingTools, _("Enable &Recording Tools"),
m_GameSettingsSubmenu.Append(MenuId_EnableInputRecording, _("Enable &Input Recording"),
wxEmptyString, wxITEM_CHECK);
#endif

Expand Down Expand Up @@ -406,14 +406,14 @@ void MainEmuFrame::CreateCdvdMenu()
m_menuCDVD.AppendSeparator();
m_menuCDVD.Append( MenuId_Src_Iso, _("&ISO"), _("Makes the specified ISO image the CDVD source."), wxITEM_RADIO );
m_menuCDVD.Append( MenuId_Src_Plugin, _("&Plugin"), _("Uses an external plugin as the CDVD source."), wxITEM_RADIO );
m_menuCDVD.Append( MenuId_Src_NoDisc, _("&No disc"), _("Use this to boot into your virtual PS2's BIOS configuration."), wxITEM_RADIO );
m_menuCDVD.Append( MenuId_Src_NoDisc, _("&No Disc"), _("Use this to boot into your virtual PS2's BIOS configuration."), wxITEM_RADIO );
}


void MainEmuFrame::CreateConfigMenu()
{
m_menuConfig.Append(MenuId_Config_SysSettings, _("Emulation &Settings...") );
m_menuConfig.Append(MenuId_Config_McdSettings, _("&Memory cards...") );
m_menuConfig.Append(MenuId_Config_McdSettings, _("&Memory Cards...") );
m_menuConfig.Append(MenuId_Config_BIOS, _("&Plugin/BIOS Selector...") );

m_menuConfig.AppendSeparator();
Expand All @@ -431,8 +431,8 @@ void MainEmuFrame::CreateConfigMenu()

m_menuConfig.AppendSeparator();

m_menuConfig.Append(MenuId_ChangeLang, L"Change &language..." ); // Always in English
m_menuConfig.Append(MenuId_Config_ResetAll, _("C&lear all settings..."),
m_menuConfig.Append(MenuId_ChangeLang, L"Change &Language..." ); // Always in English
m_menuConfig.Append(MenuId_Config_ResetAll, _("C&lear All Settings..."),
AddAppName(_("Clears all %s settings and re-runs the startup wizard.")));
}

Expand All @@ -450,8 +450,8 @@ void MainEmuFrame::CreateWindowsMenu()
void MainEmuFrame::CreateCaptureMenu()
{
m_menuCapture.Append(MenuId_Capture_Video, _("Video"), &m_submenuVideoCapture);
m_submenuVideoCapture.Append(MenuId_Capture_Video_Record, _("Start Recording"));
m_submenuVideoCapture.Append(MenuId_Capture_Video_Stop, _("Stop Recording"))->Enable(false);
m_submenuVideoCapture.Append(MenuId_Capture_Video_Record, _("Start Screenrecorder"));
m_submenuVideoCapture.Append(MenuId_Capture_Video_Stop, _("Stop Screenrecorder"))->Enable(false);

m_menuCapture.Append(MenuId_Capture_Screenshot, _("Screenshot"));
}
Expand Down Expand Up @@ -531,7 +531,7 @@ MainEmuFrame::MainEmuFrame(wxWindow* parent, const wxString& title)
// Append the Recording options if previously enabled and setting has been picked up from ini
if (g_Conf->EmuOptions.EnableRecordingTools)
{
m_menubar.Append(&m_menuRecording, _("&Recording"));
m_menubar.Append(&m_menuRecording, _("&Input Record"));
}
#endif
m_menubar.Append( &m_menuHelp, _("&Help") );
Expand Down Expand Up @@ -741,7 +741,7 @@ void MainEmuFrame::ApplyConfigToGui(AppConfig& configToApply, int flags)
menubar.Check( MenuId_EnableCheats, configToApply.EmuOptions.EnableCheats );
menubar.Check( MenuId_EnableWideScreenPatches, configToApply.EmuOptions.EnableWideScreenPatches );
#ifndef DISABLE_RECORDING
menubar.Check(MenuId_EnableRecordingTools, configToApply.EmuOptions.EnableRecordingTools);
menubar.Check( MenuId_EnableInputRecording, configToApply.EmuOptions.EnableRecordingTools);
#endif
menubar.Check( MenuId_EnableHostFs, configToApply.EmuOptions.HostFs );
menubar.Check( MenuId_Debug_CreateBlockdump, configToApply.EmuOptions.CdvdDumpBlocks );
Expand Down
10 changes: 5 additions & 5 deletions pcsx2/gui/MainMenuClicks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,23 +499,23 @@ void MainEmuFrame::Menu_EnableWideScreenPatches_Click( wxCommandEvent& )
#ifndef DISABLE_RECORDING
void MainEmuFrame::Menu_EnableRecordingTools_Click(wxCommandEvent&)
{
bool checked = GetMenuBar()->IsChecked(MenuId_EnableRecordingTools);
bool checked = GetMenuBar()->IsChecked(MenuId_EnableInputRecording);
// Confirm with User
if (checked)
{
if (!Msgbox::OkCancel(_("Please be aware that PCSX2's input recording features are still very much a work-in-progress.\n"
"As a result, there may be unforeseen bugs, performance implications and instability with certain games.\n\n"
"These tools are provided as-is and should be enabled under your own discretion."), "Enabling Recording Tools"))
"These tools are provided as-is and should be enabled under your own discretion."), "Enabling Input Recording"))
{
checked = false;
m_GameSettingsSubmenu.FindChildItem(MenuId_EnableRecordingTools)->Check(false);
m_GameSettingsSubmenu.FindChildItem(MenuId_EnableInputRecording)->Check(false);
}
}

// If still enabled, add the menu item, else, remove it
if (checked)
{
GetMenuBar()->Insert(TopLevelMenu_Recording, &m_menuRecording, _("&Recording"));
GetMenuBar()->Insert(TopLevelMenu_InputRecording, &m_menuRecording, _("&Input Record"));
// Enable Recording Keybindings
if (GSFrame* gsFrame = wxGetApp().GetGsFramePtr())
{
Expand All @@ -527,7 +527,7 @@ void MainEmuFrame::Menu_EnableRecordingTools_Click(wxCommandEvent&)
}
else
{
GetMenuBar()->Remove(TopLevelMenu_Recording);
GetMenuBar()->Remove(TopLevelMenu_InputRecording);
// Always turn controller logs off, but never turn it on by default
SysConsole.controlInfo.Enabled = checked;
// Return Keybindings Back to Normal
Expand Down
17 changes: 13 additions & 4 deletions pcsx2/gui/Panels/GSWindowPanel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,17 @@ Panels::GSWindowSettingsPanel::GSWindowSettingsPanel( wxWindow* parent )
m_check_Fullscreen = new pxCheckBox( this, _("Default to fullscreen mode on open") );
m_check_DclickFullscreen = new pxCheckBox( this, _("Double-click toggles fullscreen mode") );

m_combo_FMVAspectRatioSwitch->SetToolTip( pxEt( L"Off: Disables temporary aspect ratio switch.\n\n4:3: Temporarily switch to a 4:3 aspect ratio while an FMV plays to correctly display an 4:3 FMV.\n\n16:9: Temporarily switch to a 16:9 aspect ratio while an FMV plays to correctly display a widescreen 16:9 FMV.") );

m_text_Zoom->SetToolTip( pxEt( L"Zoom = 100: Fit the entire image to the window without any cropping.\nAbove/Below 100: Zoom In/Out\n0: Automatic-Zoom-In untill the black-bars are gone (Aspect ratio is kept, some of the image goes out of screen).\n NOTE: Some games draw their own black-bars, which will not be removed with '0'.\n\nKeyboard: CTRL + NUMPAD-PLUS: Zoom-In, CTRL + NUMPAD-MINUS: Zoom-Out, CTRL + NUMPAD-*: Toggle 100/0"
m_combo_FMVAspectRatioSwitch->SetToolTip( pxEt( L"Off: Disables temporary aspect ratio switch. (It will use the above setting from Aspect Ratio instead of FMV Aspect Ratio Override.)\n\n"
L"4:3: Temporarily switch to a 4:3 aspect ratio while an FMV plays to correctly display an 4:3 FMV.\n\n"
L"16:9: Temporarily switch to a 16:9 aspect ratio while an FMV plays to correctly display a widescreen 16:9 FMV.") );

m_text_Zoom->SetToolTip( pxEt( L"Zoom = 100: Fit the entire image to the window without any cropping.\n"
L"Above/Below 100: Zoom In/Out.\n\n"
L"0: Automatic-Zoom-In until the black-bars are gone (Aspect ratio is kept, some of the image goes out of screen).\n\n"
L"NOTE: Some games draw their own black-bars, which will not be removed with '0'.\n\n"
L"Keyboard: \n"
L"CTRL + NUMPAD-PLUS: Zoom-In, \n"
L"CTRL + NUMPAD-MINUS: Zoom-Out, \nCTRL + NUMPAD-*: Toggle 100/0"
) );

m_combo_vsync->SetToolTip( pxEt( L"Vsync eliminates screen tearing but typically has a big performance hit. It usually only applies to fullscreen mode, and may not work with all GS plugins."
Expand All @@ -81,7 +89,8 @@ Panels::GSWindowSettingsPanel::GSWindowSettingsPanel( wxWindow* parent )
m_check_HideMouse->SetToolTip( pxEt( L"Check this to force the mouse cursor invisible inside the GS window; useful if using the mouse as a primary control device for gaming. By default the mouse auto-hides after 2 seconds of inactivity."
) );

m_check_Fullscreen->SetToolTip( pxEt( L"Enables automatic mode switch to fullscreen when starting or resuming emulation. You can still toggle fullscreen display at any time using alt-enter."
m_check_Fullscreen->SetToolTip( pxEt( L"Enables automatic mode switch to fullscreen when starting or resuming emulation. You can still toggle fullscreen display at any time using \n"
L"Alt-Enter or double clicking the output window (game)."
) );

m_check_CloseGS->SetToolTip( pxEt( L"Completely closes the often large and bulky GS window when pressing ESC or pausing the emulator."
Expand Down
16 changes: 8 additions & 8 deletions pcsx2/gui/Panels/MemoryCardListView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ const ListViewColumnInfo& MemoryCardListView_Simple::GetDefaultColumnInfo( uint
{
static const ListViewColumnInfo columns[] =
{
{ _("PS2 Port") , 170 , wxLIST_FORMAT_LEFT },
{ _("PS2 Port") , 160 , wxLIST_FORMAT_LEFT },
//{ _("Port status") , 80 , wxLIST_FORMAT_LEFT },
{ _("Card (file) name") , 145 , wxLIST_FORMAT_LEFT },
{ _("Card size") , 65 , wxLIST_FORMAT_LEFT },
{ _("Formatted") , 80 , wxLIST_FORMAT_LEFT },
{ _("Type") , 60 , wxLIST_FORMAT_LEFT },
{ _("Memory card") , 145 , wxLIST_FORMAT_LEFT },
{ _("Card size") , 60 , wxLIST_FORMAT_LEFT },
{ _("Usable / Formatted") , 115 , wxLIST_FORMAT_LEFT },
{ _("Type") , 45 , wxLIST_FORMAT_LEFT },
{ _("Last Modified"), 90 , wxLIST_FORMAT_LEFT },
{ _("Created on") , 90 , wxLIST_FORMAT_LEFT },
{ _("Created on") , 80 , wxLIST_FORMAT_LEFT },
};

pxAssertDev( idx < ArraySize(columns), "ListView column index is out of bounds." );
Expand Down Expand Up @@ -162,9 +162,9 @@ wxString MemoryCardListView_Simple::OnGetItemText(long item, long column) const
// it cannot access GetMcdProvider() which isn't (and shouldn't be) const.
//so.. a plain old cast does the trick. Hope it's not too bad. - avih.
if (((MemoryCardListView_Simple*)this)->GetMcdProvider().IsNonEmptyFilesystemCards())
return _("[-- Unused cards --]");
return _("[-- Disabled cards --]");
else
return _("[-- No unused cards --]");
return _("[-- No cards --]");
}

wxDirName filepath( it.Filename.GetPath() );
Expand Down
6 changes: 3 additions & 3 deletions pcsx2/gui/Panels/VideoPanel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Panels::FramelimiterPanel::FramelimiterPanel( wxWindow* parent )
: BaseApplicableConfigPanel_SpecificConfig( parent )
{
m_check_LimiterDisable = new pxCheckBox( this, _("Disable Framelimiting"),
_("Useful for running benchmarks. Toggle this option in-game by pressing F4.") );
_("Uncaps FPS. Toggle in-game by pressing F4. Useful for running benchmarks." ) );

m_check_LimiterDisable->SetToolTip( pxEt( L"Note that when Framelimiting is disabled, Turbo and SlowMotion modes will not be available either."
) );
Expand All @@ -43,7 +43,7 @@ Panels::FramelimiterPanel::FramelimiterPanel( wxWindow* parent )
m_text_BasePal = CreateNumericalTextCtrl( this, 7 );

m_spin_NominalPct ->SetRange( 10, 1000 );
m_spin_SlomoPct ->SetRange( 1, 1000 );
m_spin_SlomoPct ->SetRange( 5, 1000 );
lightningterror marked this conversation as resolved.
Show resolved Hide resolved
m_spin_TurboPct ->SetRange( 10, 1000 );

// ------------------------------------------------------------
Expand Down Expand Up @@ -293,7 +293,7 @@ Panels::VideoPanel::VideoPanel( wxWindow* parent ) :

m_restore_defaults = new wxButton(right, wxID_DEFAULT, _("Restore Defaults"));

m_check_SynchronousGS->SetToolTip( pxEt( L"Enable this if you think MTGS thread sync is causing crashes or graphical errors.")
m_check_SynchronousGS->SetToolTip( pxEt( L"Enable this if you think MTGS thread sync is causing crashes or graphical errors. For debugging to see if GS is running at the correct speed.")
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For debugging to see if GS is running at the correct speed

Not sure what the validity behind this statement is and considering that I wouldn't feel comfortable saying it's one of the reasons the setting exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest i've heard multiple things about this setting, to a legacy setting to putting on a separate thread. I've already deleted Debug tag on the description itself.

) ;

//GSWindowSettingsPanel* winpan = new GSWindowSettingsPanel( left );
Expand Down