Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zerogs and zerospu2 from master branch #3623

Merged
merged 6 commits into from
Aug 23, 2020
Merged

Conversation

lightningterror
Copy link
Contributor

No description provided.

@arcum42
Copy link
Contributor

arcum42 commented Aug 23, 2020

Main thing that stands out is in GameIndex.dbf:

Serial = PBPX-95506
Name   = Playstation 2 - Demo Disc 2001
Region = PAL-M5
[patches]
	// 7ACF7E03
	comment=You must enable the EETimingHack when playing the WRC demo to avoids random hangs.
	comment=You must change the EE Clamping mode to Full when playing the Klonoa 2 demo to avoids misplaced objects.
	comment=You must change the VU Clamping mode to extra when playing the Klonoa 2 demo to fixes reflections issues.
	comment=You must use the ZeroSPU2 plugin when playing the Klonoa 2 demo to avoids bad/missing sounds.
[/patches]

We probably shouldn't be recommending a plugin we're removing. Is that even true any more?

@orbea

This comment has been minimized.

@arcum42
Copy link
Contributor

arcum42 commented Aug 23, 2020

Yes. I didn't see any reason to get rid of them. For example, ZeroSPU2 no longer being there doesn't mean that Alsa.cpp is no longer based on code from it...

@orbea

This comment has been minimized.

@arcum42
Copy link
Contributor

arcum42 commented Aug 23, 2020

On the dummy function, I'd just be worried about breaking something inadvertently when deleting it, so I'd tend towards having getting rid of that be a separate commit and not mixed into this pr.

And on the registers comment, if I was touching that code, I'd rather have the historical context there, so I knew why things had been handled that way previously.

@lightningterror
Copy link
Contributor Author

Yeah I left all those on purpose for those reasons.

Copy link
Contributor

@arcum42 arcum42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're probably fine, then.

@lightningterror lightningterror merged commit 3324043 into master Aug 23, 2020
@lightningterror lightningterror deleted the omae-wa-mou branch August 23, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants