-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zerogs and zerospu2 from master branch #3623
Conversation
Main thing that stands out is in GameIndex.dbf:
We probably shouldn't be recommending a plugin we're removing. Is that even true any more? |
This comment has been minimized.
This comment has been minimized.
Yes. I didn't see any reason to get rid of them. For example, ZeroSPU2 no longer being there doesn't mean that Alsa.cpp is no longer based on code from it... |
This comment has been minimized.
This comment has been minimized.
On the dummy function, I'd just be worried about breaking something inadvertently when deleting it, so I'd tend towards having getting rid of that be a separate commit and not mixed into this pr. And on the registers comment, if I was touching that code, I'd rather have the historical context there, so I knew why things had been handled that way previously. |
Yeah I left all those on purpose for those reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we're probably fine, then.
No description provided.