Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-gui: Add dithering option to windows gui #3706

Merged
merged 1 commit into from
Sep 18, 2020
Merged

GSdx-gui: Add dithering option to windows gui #3706

merged 1 commit into from
Sep 18, 2020

Conversation

RedDevilus
Copy link
Contributor

@RedDevilus RedDevilus commented Sep 17, 2020

Copy link
Member

@tadanokojin tadanokojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@RedDevilus
Copy link
Contributor Author

Conflict with bottom buttons for unknown reason (i fixed conflict and rebased):
image

@RedDevilus
Copy link
Contributor Author

RedDevilus commented Sep 18, 2020

This was the intended effect, but i will need another PR to fix it:
Current status:
image

- Dropdown menu for 3 options: Off (No Effect/ Been always like this), Scaled (Strongest effect/obvious), Unscaled (Weakest effect/less obvious)
- Change default from Scaled to Unscaled
@lightningterror lightningterror merged commit 4e13c33 into PCSX2:master Sep 18, 2020
@lightningterror lightningterror added this to the Release 1.8 milestone Sep 18, 2020
@lightningterror lightningterror changed the title GSdx-gui: Add dithering GSdx-gui: Add dithering option to windows gui Sep 18, 2020
@Nicholas-Steel
Copy link

There is currently no on-hover tooltip for this option. Dunno if this should be a separate bug report.

@RedDevilus
Copy link
Contributor Author

I intend to implement other tooltips when Linux is on the level of windows wx.

@lightningterror
Copy link
Contributor

There's no need for every option to have a tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Dithering mode option to GSdx UI
4 participants