Replace cached GSOffset with live calculations

[TellowKrinkle]

Should fix #2686, please test

The non-cached calculations are pretty fast, but generally not quite as fast as the cached versions. I haven't noticed any slowdown in anything I've tested, but it might be good for others to test.

Also this makes heavy use of lambdas hoping they'll be inlined, so we should performance test MSVC and make sure it actually does

Finally, we haven't used them much before, so what are people's thoughts on formatting lambdas passed to functions? I went with this (indented like you would the content of a loop):

s->m_pages.loopPages([this, s](uint32 page)
{
	s->m_erase_it[page] = m_map[page].InsertFront(s);
});

but we could also go with this

s->m_pages.loopPages([this, s](uint32 page)
	{
		s->m_erase_it[page] = m_map[page].InsertFront(s);
	});

or this

s->m_pages.loopPages(
	[this, s](uint32 page)
	{
		s->m_erase_it[page] = m_map[page].InsertFront(s);
	});

I personally would like to not go with clang-format's preference of this, it destroys horizontal space

s->m_pages.loopPages([this, s](uint32 page)
                     {
                         s->m_erase_it[page] = m_map[page].InsertFront(s);
                     });

Same question for locals

auto helper = [&](...)
{
};

or

auto helper = [&](...)
	{
	};

[seta-san]

tour de france doesn't have memory leak anymore. memory usage doesn't get much higher than 560mb. characters and other UI elements flicker in and out of existence which is new (incorrect) behavior.

https://youtu.be/msNw_BPzrAs

[seta-san]

multiframe dump.
https://filebin.net/dham5zxe2g89mb8e

[TellowKrinkle]

@seta-san try now

[seta-san]

@seta-san try now

works perfect now.

[MrPopoJunior]

Is this fix gonna be included in a dev build of PCSX2?

[F0bes]

Once the PR is merged into master, it will be in the latest dev build yes.

[iMineLink]

This was a micro optimization from greg for reducing the source cache invalidation time with the old page validity bitmap; It might be a good benchmark to compare the time spent in the GSTextureCache::SourceMap::RemoveAt before and after the modifications.

[TellowKrinkle]

Hmm the two commits that modified it before were fa1377a and e58776e

fa1377a looks like it was adding a caching system that's since been replaced, though it does name Champion of Norrath as the game to profile for this section of code

e58776e is the one that adds the _BitScanForward and doesn't mention what games it's trying to improve

So does anyone have Champion of Norrath (or a gsdump of it) to profile?

[refractionpcsx2]

Champions of Norrath is just a Snowblind engine game, so any game using that, for example Baldurs Gate, will probably do.

[iMineLink]

My memory has betrayed me about the git history, sorry. Anyway I tested the beginning of Baldur's Gate: Dark Alliance, and it is even a tad faster now! Great job.

[ThatDudeYouMetThatOneTime]

Just an update, since it's been a few months since my last comment on this build. I was able to complete Remote Control Dandy SF 100% using this build. I only encountered some geometry issues during cutscenes, but everything was near-perfect during gameplay. The only other issue I had was some random crashes which happened hours apart from eachother, so I'm attributing those to the nature of this being an experimental PR build.

[ThatDudeYouMetThatOneTime]

This build seems to have fixed the issue with Remote Control Dandy SF, which would cause the game to crash after about 10 to 15 minutes of playing. In my testing thus far, I have been able to play the game for an hour and 10 minutes without experiencing any crashes. If anyone else would be interested in testing RCD SF with this build as well, and for a longer period of time, please feel free to do so.

[seta-san]

This build seems to have fixed the issue with Remote Control Dandy SF, which would cause the game to crash after about 10 to 15 minutes of playing. In my testing thus far, I have been able to play the game for an hour and 10 minutes without experiencing any crashes. If anyone else would be interested in testing RCD SF with this build as well, and for a longer period of time, please feel free to do so.

ANOTHER KONAMI GAME

[RedDevilus]

Ultimate Spider-man doesn't seem to crash anymore even after 30 min, though the game suffers from other problems like texture cache.

[seta-san]

this may also effect "Anubis: Zone of Enders"

from 5chan
658名無しさん＠お腹いっぱい。 (ﾜｯﾁｮｲ 9b62-0pr0)2021/04/06(火) 11:13:37.76ID:+rNq7+UQ0
anubisのメモリリークも解消されますように(May anubis memory leaks be eliminated.)

[TellowKrinkle]

Speaking of 5ch

試したいけどgithub使ったことがなくてやり方が分からない

1. 右上のSign Upのボタンで無料でgithubのアカウントを作ろう。
2. 緑色の✔︎をクリックして、Windows buildの右のDetailsと言うボタンをクリック
   
3. ログインしているならArtifactsが表示される。そこでPCSX2-32bit-pr...をダウンロードする
   
4. 問題があれば公式Discordサーバーの#help-windowsチャンネルで聞いてください。日本語で聞いても時間がちょっとかかるが日本語のできる人がきっと手伝うよ

[F0bes]

Tested with Colin McRae Rally 3 and Grand Theft Auto: LCS

Both seem to work fine, CM Rally seemed to be a couple of fps faster
GTA: LCS seemed to be a touch slower

The difference is very minuscule and could just external factors.

[ghost]

This PR produces visual glitches on Zone of the enders the 2nd runner demo.

[TellowKrinkle]

This PR produces visual glitches on Zone of the enders the 2nd runner demo.

Send a GSdump please

[refractionpcsx2]

Not really a bug but an observation, there's a 2D screen after the main menu of Drakengard which on Master starts around 70fps and then drops down to 40fps after a few seconds (toggling F9 brings it back up for a short while), however on this PR it is constantly at 40fps no matter what. This is obviously evidence of the game spamming crap to flush the draws or something, but I figured it interesting to mention.

I should note that Software mode sits around 60-90fps

[Rasiohead91]

how to install this update on the pcsx2? I am just rookie

[Mrlinkwii]

@Rasiohead91 go to https://pcsx2.net/downloads/ and scroll down to where you see 1.7.27XX , if you have any other issues join the discord/ forums thats linked in the readme :) ,

[Rasiohead91]

@Rasiohead91 go to https://pcsx2.net/downloads/ and scroll down to where you see 1.7.27XX , if you have any other issues join the discord/ forums thats linked in the readme :) ,

3q very much,and the latest version is the best?

[RedDevilus]

@Rasiohead91 go to pcsx2.net/downloads and scroll down to where you see 1.7.27XX , if you have any other issues join the discord/ forums thats linked in the readme :) ,

3q very much,and the latest version is the best?

I would assume having a big ass button would tell you that yes, the latest version is the best.