GS: MLB Power Pros crash #2686

MrCK1 · 2018-11-15T03:31:21Z

PCSX2 version:
v1.5.0-dev-2671-gca68ddd0d

PCSX2 options:
Defaults

Plugins used:
GSdx-AVX2, Defaults

Description of the issue:
This change introduced a memory leak for all renderers of GSdx in rare cases such as MLB Power Pros.

How to reproduce the issue:
Boot the game, find a section with 3D rendering.

Last known version to work:
r1548, introduced in r1549

PC specifications:
i5-6600K@4.7GHz, GTX 1070, Windows 10 64-Bit Home.

In GSState.cpp:

template<int i> void GSState::ApplyTEX0(GIFRegTEX0& TEX0)
{
	GL_REG("Apply TEX0_%d = 0x%x_%x", i, TEX0.u32[1], TEX0.u32[0]);

	// Handle invalid PSM here
	switch (TEX0.PSM) {
		case 3:
			TEX0.PSM = PSM_PSMT8; // International Star Soccer (menu)
			break;
		default:
			break;
	}

	// even if TEX0 did not change, a new palette may have been uploaded and will overwrite the currently queued for drawing
	bool wt = m_mem.m_clut.WriteTest(TEX0, m_env.TEXCLUT);

	// clut loading already covered with WriteTest, for drawing only have to check CPSM and CSA (MGS3 intro skybox would be drawn piece by piece without this)

	uint64 mask = 0x1f78001c3fffffffull; // TBP0 TBW PSM TW TCC TFX CPSM CSA

	if(wt || PRIM->CTXT == i && ((TEX0.u64 ^ m_env.CTXT[i].TEX0.u64) & mask))
	{
		Flush();
	}

	TEX0.CPSM &= 0xa; // 1010b

	if((TEX0.u32[0] ^ m_env.CTXT[i].TEX0.u32[0]) & 0x3ffffff) // TBP0 TBW PSM
	{
		m_env.CTXT[i].offset.tex = m_mem.GetOffset(TEX0.TBP0, TEX0.TBW, TEX0.PSM);


	}

In the bottom if statement: commenting out m_env.CTXT[i].offset.tex = m_mem.GetOffset(TEX0.TBP0, TEX0.TBW, TEX0.PSM); will resolve the memory leak.

The text was updated successfully, but these errors were encountered:

arcum42 · 2018-11-15T04:00:10Z

Just a guess, but maybe we should delete m_env.CTXT[i].offset.tex before assigning something new to it?

turtleli · 2018-11-15T09:11:32Z

Test if changing

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Line 497 in ca68ddd

for(auto &i : m_omap) _aligned_free(i.second);

to

for(auto &i : m_omap) delete i.second;

works. The memory is allocated with new, not _aligned_malloc, so it should be deleted with delete, not _aligned_free.

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Lines 518 to 520 in ca68ddd

    
           GSOffset* off = new GSOffset(bp, bw, psm); 
        
           m_omap[hash] = off;

MrCK1 · 2018-11-15T14:25:09Z

Unfortunately that change didn't work. Let me know if there's any other info I should post/look for.

iMineLink · 2018-11-15T14:51:53Z

Maybe the problem is in the GSOffset constructor?
I see in the line:
m_env.CTXT[i].offset.tex = m_mem.GetOffset(TEX0.TBP0, TEX0.TBW, TEX0.PSM);,
which removal fixes the leak, the called function m_mem.GetOffset creates the new GSOffset object:

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Line 507 in ca68ddd

GSOffset* GSLocalMemory::GetOffset(uint32 bp, uint32 bw, uint32 psm)

So maybe in the constructor at:

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Line 2049 in ca68ddd

GSOffset::GSOffset(uint32 _bp, uint32 _bw, uint32 _psm)

there is the root cause of the leak in that case.

RinMaru · 2018-11-15T14:52:45Z

is this a memory leak like in destroy all humans and in street racing syndicate?

MrCK1 · 2018-11-15T15:05:34Z

@RinMaru Not sure. (There's a few different ways GSdx can hog memory) See if they leak with this test plugin. If they don't, it would be safe to say that those games are affected by this issue as well.

(rename the extension to .dll. Also, make sure you give it some time to sit while testing. MLB Power Pros still tends to use a bit more memory then other games do but after a minute or so, the memory usage will hover around a fixed amount.

GSdx32-SSE2_memleak_wip.zip

RinMaru · 2018-11-15T16:29:26Z

hmm it might be a diff issue since it has no affect on either titles CPU and ram just start choking. don't have MLB to test

MrCK1 · 2018-11-15T18:13:52Z

@turtleli @AlessandroVetere Would this be a logical change? I replaced _aligned_free with delete and it seems to stop the leak.

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Lines 2077 to 2081 in ca68ddd

    
           GSOffset::~GSOffset() 
        
           { 
        
           	for(auto buffer: pages_as_bit) 
        
           		_aligned_free(buffer); 
        
           }

turtleli · 2018-11-15T22:07:54Z

I don't think that's correct. The memory there is allocated with _aligned_malloc, so using _aligned_free there should be correct.

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Lines 2160 to 2162 in ca68ddd

    
           // Aligned on 64 bytes to store the full bitmap in a single cache line 
        
           pages = (uint32*)_aligned_malloc(MAX_PAGES/8, 64); 
        
           pages_as_bit[hash_key] = pages;

lightningterror · 2018-11-16T20:05:18Z

@MrCK1 Maybe upload a blockdump with a savestate as well so others can help with solving the issue.

iMineLink · 2018-11-18T14:00:34Z

Nvm; I confused an array with map.

iMineLink · 2018-11-18T14:54:42Z

Is this ever deleted?

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Line 2103 in ca68ddd

pages = new uint32[limit];

EDIT: this seems to affect only SW mode, and there the deletion of such allocation is managed by GSTextureCacheSW or GSRendererSW

MrCK1 · 2018-11-18T18:20:41Z

It doesn't look like it's deleted anywhere but fiddling around with that didn't have an effect.

MrCK1 · 2018-11-18T23:30:29Z

Here is a blockdump and savestate for anybody else who feels like testing. Unfortunately, the blockdump uncompressed is 1GB in size due to the memory leak I presume. (You'll have to press X 2-3 times to go-ingame where the leak occurs.)

(rename to .7z)
MLB_PowerPros_Blockdump.zip

iMineLink · 2018-11-20T21:58:34Z

Couldn't it be that the GSLocalMemory::GetOffset function, which is the only place in the code (correct me if I'm wrong) it is allocated a new GSOffset object, just accumulates too many GSOffset objects in the m_omap cache of GSLocalMemory?

pcsx2/plugins/GSdx/GSLocalMemory.cpp

Lines 518 to 520 in ca68ddd

    
           GSOffset* off = new GSOffset(bp, bw, psm); 
        
           m_omap[hash] = off;

Maybe we should check if the cache has too many items and clear it before adding a new entry.

EDIT: In fact, offsets allocated with GSLocalMemory::GetOffset are never deleted during normal usage.

tadanokojin · 2018-11-20T22:01:36Z

FWIW

EDIT: No idea why this happens. I have games that hit this line of code and don't have this leak (at least not that I've noticed). DoC: FFVII hits that same line of code.

iMineLink · 2018-11-20T22:17:31Z

Aaand the line calling GSLocalMemory::GetOffset is just the one which removed fixes the leak as indicated by OP:

pcsx2/plugins/GSdx/GSState.cpp

Line 909 in 1498f53

m_env.CTXT[i].offset.tex = m_mem.GetOffset(TEX0.TBP0, TEX0.TBW, TEX0.PSM);

In fact GSOffset objects are never deleted until the GSLocalMemory is, they are just accumulated in the cache.
So we might need to clean the cache from time to time, requiring usage of shared pointers and such to safe deleting items before insert.
Refactoring the code could be a PITA though.

gregory38 · 2018-11-23T20:07:26Z

Is the "leak" that big ? The number of GSoffset should be limited as you have 1 by texture "format".

MrCK1 · 2018-11-23T20:11:16Z

I'd say so. In this instance, memory usage will reach 2GB in about 40 seconds.

Lothar635 · 2019-05-07T15:46:16Z

https://github.com/PCSX2/pcsx2/blob/master/plugins/GSdx/GSDrawingContext.h#L84
Just a thought, but wold this line serve better in the reset() function? The GSOffset's would be reset each time the reset() function is called, instead of only when the GSDrawingContext() function is called (which calls reset() anyway).

MrCK1 · 2019-08-01T02:19:57Z

I'm going to go ahead and say this issue has been resolved, retested with dev-3205 in DX11/OGL and seems to have no spikes with VRAM usage, crashing, ect. (Sparse texture hack was disabled for these tests of course)

This is likely due to the recent changes that have been made to texture cache by @AlessandroVetere and @gregory38 . If the issue pops up again, we'll go from there :)

tadanokojin · 2020-12-03T12:40:50Z

Game is spamming nonsense TEX0 writes which is filling up the GSOffset cache:

bp: 35c1, bw: 53, psm: 1a
bp: 228c, bw: 60, psm: 0
bp: 1b46, bw: 61, psm: 2
bp: 3cad, bw: 11, psm: 16
bp: 2985, bw: 35, psm: 1e
bp: 1f5e, bw: 53, psm: 1a
bp: c0f, bw: 62, psm: 31
bp: 1660, bw: 53, psm: 32
bp: 3fad, bw: 42, psm: 11
bp: 14e1, bw: 39, psm: 1d
bp: 29f6, bw: 1, psm: 20
bp: 15d7, bw: 7, psm: 17
bp: 3be4, bw: 18, psm: 21
bp: 1e51, bw: 11, psm: 1b
bp: 3e9d, bw: 56, psm: 33
bp: 3b0e, bw: 44, psm: 2e
bp: 2bf1, bw: 42, psm: 37
bp: 2318, bw: 7, psm: 3d
bp: 30be, bw: 23, psm: e
bp: cdf, bw: 26, psm: b
bp: a4d, bw: 30, psm: 38
bp: 32a5, bw: 41, psm: 34
bp: 30e7, bw: 39, psm: 23
bp: e01, bw: 25, psm: 38
bp: 1518, bw: 44, psm: 3f
bp: edd, bw: 62, psm: 6
bp: 1174, bw: 48, psm: 1f
bp: 2857, bw: 62, psm: 37
bp: 1f9, bw: 62, psm: 37
bp: 37bd, bw: 15, psm: c
bp: 1015, bw: 55, psm: 37
bp: 2e51, bw: 54, psm: 39
bp: 25b3, bw: 19, psm: 32
bp: 2d2a, bw: 29, psm: 10
bp: 899, bw: 2, psm: 0
bp: 14a5, bw: 54, psm: 30
bp: c94, bw: 59, psm: 30
bp: edc, bw: 44, psm: 5
bp: 3f37, bw: 54, psm: 30
bp: 1f8a, bw: 57, psm: 32
bp: 74, bw: 34, psm: 38

tadanokojin · 2020-12-08T17:17:15Z

We can add Bouken Jidai Katsugeki Goemon to the list of games affected by this.

seta-san · 2021-01-09T19:26:34Z

le tour de france and le tour de france centenary edition seems to have the same issue.

https://forums.pcsx2.net/Thread-Le-Tour-de-France-Centenary-Edition-SLES-51488-E?pid=616517#pid616517
https://forums.pcsx2.net/Thread-Le-Tour-de-France-SLES-50570-E--28356?pid=432709#pid432709

seta-san · 2021-02-05T09:07:24Z

5ch.net I am trying to monitor your image boards for issues with Japanese games. Since Americans can't post I'm trying to get your attention here.

seta-san · 2021-04-05T14:38:23Z

Also affects "Remote Control Dandy SF"

MrCK1 added Bug GS Regression labels Nov 15, 2018

lightningterror added the High Priority label Nov 15, 2018

ssakash pinned this issue Jul 26, 2019

lightningterror unpinned this issue Jul 27, 2019

MrCK1 added the Fixed label Aug 1, 2019

MrCK1 closed this as completed Aug 1, 2019

tadanokojin reopened this Dec 3, 2020

tadanokojin self-assigned this Dec 3, 2020

tadanokojin removed the Fixed label Dec 3, 2020

tadanokojin changed the title ~~GSdx: Ancient memory leak (need ideas for fixing)~~ GS: MLB Power Pros crash Dec 3, 2020

tadanokojin removed the High Priority label Dec 3, 2020

$@refractionpcsx2$ refractionpcsx2 mentioned this issue Dec 14, 2020

GSDX regression-crash on konami games (Goemon) #454

Closed

TellowKrinkle mentioned this issue Apr 2, 2021

Replace cached GSOffset with live calculations #4348

Merged

$@refractionpcsx2$ refractionpcsx2 closed this as completed in #4348 Nov 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GS: MLB Power Pros crash #2686

GS: MLB Power Pros crash #2686

MrCK1 commented Nov 15, 2018 •

edited

Loading

arcum42 commented Nov 15, 2018

turtleli commented Nov 15, 2018

MrCK1 commented Nov 15, 2018

iMineLink commented Nov 15, 2018

RinMaru commented Nov 15, 2018

MrCK1 commented Nov 15, 2018

RinMaru commented Nov 15, 2018

MrCK1 commented Nov 15, 2018

turtleli commented Nov 15, 2018

lightningterror commented Nov 16, 2018

iMineLink commented Nov 18, 2018 •

edited

Loading

iMineLink commented Nov 18, 2018 •

edited

Loading

MrCK1 commented Nov 18, 2018

MrCK1 commented Nov 18, 2018 •

edited

Loading

iMineLink commented Nov 20, 2018 •

edited

Loading

tadanokojin commented Nov 20, 2018 •

edited

Loading

iMineLink commented Nov 20, 2018

gregory38 commented Nov 23, 2018

MrCK1 commented Nov 23, 2018

Lothar635 commented May 7, 2019

MrCK1 commented Aug 1, 2019

tadanokojin commented Dec 3, 2020

tadanokojin commented Dec 8, 2020

seta-san commented Jan 9, 2021

seta-san commented Feb 5, 2021

seta-san commented Apr 5, 2021

GS: MLB Power Pros crash #2686

GS: MLB Power Pros crash #2686

Comments

MrCK1 commented Nov 15, 2018 • edited Loading

arcum42 commented Nov 15, 2018

turtleli commented Nov 15, 2018

MrCK1 commented Nov 15, 2018

iMineLink commented Nov 15, 2018

RinMaru commented Nov 15, 2018

MrCK1 commented Nov 15, 2018

RinMaru commented Nov 15, 2018

MrCK1 commented Nov 15, 2018

turtleli commented Nov 15, 2018

lightningterror commented Nov 16, 2018

iMineLink commented Nov 18, 2018 • edited Loading

iMineLink commented Nov 18, 2018 • edited Loading

MrCK1 commented Nov 18, 2018

MrCK1 commented Nov 18, 2018 • edited Loading

iMineLink commented Nov 20, 2018 • edited Loading

tadanokojin commented Nov 20, 2018 • edited Loading

iMineLink commented Nov 20, 2018

gregory38 commented Nov 23, 2018

MrCK1 commented Nov 23, 2018

Lothar635 commented May 7, 2019

MrCK1 commented Aug 1, 2019

tadanokojin commented Dec 3, 2020

tadanokojin commented Dec 8, 2020

seta-san commented Jan 9, 2021

seta-san commented Feb 5, 2021

seta-san commented Apr 5, 2021

MrCK1 commented Nov 15, 2018 •

edited

Loading

iMineLink commented Nov 18, 2018 •

edited

Loading

iMineLink commented Nov 18, 2018 •

edited

Loading

MrCK1 commented Nov 18, 2018 •

edited

Loading

iMineLink commented Nov 20, 2018 •

edited

Loading

tadanokojin commented Nov 20, 2018 •

edited

Loading