Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdio console on mac #4756

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Stdio console on mac #4756

merged 2 commits into from
Sep 22, 2021

Conversation

TellowKrinkle
Copy link
Member

Description of Changes

Enables the "Program Log to Stdio" menu option on macOS
Also makes it check the console for color support before trying to use color escapes

Rationale behind Changes

It's useful on macOS too

Suggested Testing Steps

Make sure option works on macOS and Linux

F0bes
F0bes approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-based onto master locally.
Works fine on Linux, logging gets redirected to console and colours are still there.

@TellowKrinkle TellowKrinkle merged commit ffbfd2c into PCSX2:master Sep 22, 2021
@TellowKrinkle TellowKrinkle deleted the StdioConsoleMac branch September 22, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrlinkwii Mrlinkwii Mrlinkwii approved these changes

@F0bes F0bes F0bes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TellowKrinkle @Mrlinkwii @F0bes