gs: test for th for tex0 flush #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous code didn't test TH which was a problem for vampire nights because they upload a c16 texture to the same address but with a different height
|
Wow that was fast, awsome work! The game is now indeed fine.
I will also check MGS3 and perf impact. |
|
LGTM, fixes the issue and causes no impact to other games. Also as a side effect I think my penis grew but a few inches, probably not intended tho |
|
Same here, doesn't seem to cause any problems or perf impact. As for the side effect, well.. I knew you love GSchan ref, can't hide it from me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
previous code didn't test TH which was a problem for vampire nights because they upload a c16 texture to the same address but with a different height
Rationale behind Changes
fixes #4805
Suggested Testing Steps
make sure nothing has any perf issues