Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AppRun hook to handle variables #4978

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Create AppRun hook to handle variables #4978

merged 4 commits into from
Dec 28, 2021

Conversation

qurious-pixel
Copy link
Contributor

Description of Changes

Fixes change to Appimage, requiring second boot to use the custom config file folder.

Rationale behind Changes

fix a feature that changed

Suggested Testing Steps

TellowKrinkle
TellowKrinkle approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@TellowKrinkle TellowKrinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why my review was requested here (no clue how AppImage works) but it looks fine from a bash scripting perspective I guess

@qurious-pixel
Copy link
Contributor Author

Needs testing.

Fixes config files not being set on first boot.

@Mrlinkwii
Copy link
Contributor

the PR fixes the issue , 👍

@refractionpcsx2 refractionpcsx2 merged commit d0de8d2 into PCSX2:master Dec 28, 2021
@qurious-pixel qurious-pixel deleted the patch-4 branch December 28, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TellowKrinkle TellowKrinkle TellowKrinkle approved these changes

@Mrlinkwii Mrlinkwii Mrlinkwii approved these changes

@arcum42 arcum42 Awaiting requested review from arcum42

Assignees
No one assigned
Labels
Build | Project System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qurious-pixel @Mrlinkwii @TellowKrinkle @refractionpcsx2