mVU: Rework multiple branch chaining #5391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
mvu_branchx3
branch
from
6226793
to
fa3a5e8
Compare
refractionpcsx2
force-pushed
the
mvu_branchx3
branch
from
fa3a5e8
to
80552e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Reworks the handling of branches (with links) in delay slots and chains of 3 or more branches.
Rationale behind Changes
Linking inside delay slots wasn't..right (or at least the flow is strange), but chaining 3 or more branches together just didn't work correctly, at all, the fact games worked was by sheer fluke.
Suggested Testing Steps
Test any games that do branches/jumps (especially ones that link like BAL or JALR!) in delay slots, and especially games that to "branch, branch, branch!"
Fixes #5384