PCSX2-GUI: Rename Interlacing to Deinterlacing #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So to sketch what is an annoying issue is that this for years has been wrongly presented to users. None Interlacing = Interlacing but if used with a no-interlacing patch it will look like progressive but PCSX2 or really the internal PS2 side only detects interlacing mode. Which blows my mind that the user wouldn't be wrong to assume that None Interlacing = Interlacing. Weave = Interlacing method (saw-tooth) Bob = Likely the sharpest but can do vertical bouncing. Blending = A bit blurry but the most consistent and has no bouncing. I didn't change the code just the visual presentation to the users. Example in gif format: https://upload.wikimedia.org/wikipedia/de/1/1e/Interlaced_Animation.gif
|
Example in WX: |
|
Sorry if this is an obvious question, but is there a reason that the GS output cannot simply be fed to the deinterlacing units of the graphics cards? |
|
@fallaha56 I'm not a GS developer, I only know that PS2 emulation is a pain and that everything there is for a reason. PS2 does not have a GPU but it does have a rasterizer and that game developers did their own thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rename the string Interlacing to Deinterlacing for WX and Qt
Rationale behind Changes
So to sketch what is an annoying issue is that this for years has been wrongly presented to users.
None Interlacing = Interlacing but if used with a no-interlacing patch it will look like progressive but PCSX2 or really the internal PS2 side only detects interlacing mode. Which blows my mind that the user wouldn't be wrong to assume that None Interlacing = Interlacing.
Weave = Interlacing method (saw-tooth)
Bob = Likely the sharpest but can do vertical bouncing.
Blending = A bit blurry but the most consistent and has no bouncing.
I didn't change the code just the visual presentation to the users.
Example in gif format:
Suggested Testing Steps