Qt: Fix bugs relating to per-game settings #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheLastRar
|
|
|
|
Can you provide me reproduction steps for the Anisotropic Filtering bug. I think I'm aware of that issue, but I would need more information to confirm |
1 open per-game setting window
|
TheLastRar
force-pushed
the
Qt-Per-Game-Settings-Fixes
branch
from
0492d89
to
29e0d7f
Compare
|
I did fix alot of the issues reported The Renderer dropdown and Enable Game Fixes checkbox have not been fixed, I'm considering that outside the scope of this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix the following bugs
One of the overloads for BindWidgetToEnumSetting() would select the wrong index if a per-game setting differed from global
setStringSettingValue would try to save the string as a bool when saving as a per-game setting
Rationale behind Changes
Bug fixes
Suggested Testing Steps
The DEV9 Qt PR UI has these fixes, and code that makes use of these functions, so you can check if it works there.
Other than that I guess a unit test can be written to test these functions.