Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: GS HW Fix XI #5745

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

RedDevilus
Copy link
Contributor

@RedDevilus RedDevilus commented Mar 22, 2022

Description of Changes

  • Atelier Iris 3 - Grand Phantasm
  • Baldur's Gate - Dark Alliance 1 / 2
  • Call of Duty 2 - Big Red One
  • Dark Cloud 1 / 2
  • Mana Khemia 1 / 2
  • Sims 2 - Castaway
  • Valkyrie 2 - Silmeria

Rationale behind Changes

Less tinkering.

Suggested Testing Steps

Test this Square Enix game called Valkyrie 2. + other games.

@RedDevilus RedDevilus marked this pull request as draft March 23, 2022 23:25
@RedDevilus RedDevilus changed the title GameDB: Valkyrie 2 GameDB: GS HW Fix XI Mar 24, 2022
@RedDevilus RedDevilus marked this pull request as ready for review March 24, 2022 03:56
@refractionpcsx2
Copy link
Member

Any reason to not use RoundSprite Full on Valkyrie Profile 2?

Half:
image

Full:
image

Sure it's not perfect, but it's better here, how does it perform in the area you tested?

@RedDevilus
Copy link
Contributor Author

Hmm, full roundsprite seems indeed better. I'll change it ASAP.

@nolrinale
Copy link

Screen Shot 2022-03-24 at 14 42 18

Screen Shot 2022-03-24 at 14 46 02

Screen Shot 2022-03-24 at 14 46 34

Screen Shot 2022-03-24 at 14 45 36

With the same settings (x3 upscale) areas without too many glow effects such as some towns will look very sharp but the ones with effects will look very blurry and buggy, in this game the majority are the later.

@refractionpcsx2
Copy link
Member

well, you're using patches to remove the effects, so I don't really count that. Try again without your patches and then we can consider it.

@RedDevilus RedDevilus force-pushed the GameDB-Valkyrie2 branch 3 times, most recently from 3e93e26 to afd1993 Compare March 24, 2022 15:42
@nolrinale
Copy link

nolrinale commented Mar 24, 2022

well, you're using patches to remove the effects, so I don't really count that. Try again without your patches and then we can consider it.

I tried again with CRC hacks set to None (debug), 3x and enabling only "Round Sprite" set to Full on HW Hacks tab the results are the same as the screenshots I posted above.

I also tried setting it to just "Half" and the results are a smoother screen but the blur gets more prominent, and with "Full" I get a sharper picture but there are a very noticeable weird invisible vertical line banding.

With Round Sprite "Full"
image

With Round Sprite "Half"
Screen Shot 2022-03-24 at 18 01 42

@Dreadmoth
Copy link
Contributor

Trilinear filtering might not be ideal for Baldur's Gate Dark Alliance / Champions of Norrath.

The only combination of settings that cause trilinear filtering to affect the fonts at all for me is:
• Vulkan renderer
• Texture filtering set to anything other than Bilinear (Forced)
• GPU palette conversion disabled

...which produces a result almost identical to setting Bilinear (Forced) texture filtering (without trilinear), but with a significantly larger hit to performance (54 FPS vs. 37 FPS in one heavy scene in Champions).


FMV software renderer switch may be unnecessary for the PAL versions of Baldur's Gate: Dark Alliance and Dark Alliance II - the videos look fine on all hardware renderers for me.

@RedDevilus RedDevilus force-pushed the GameDB-Valkyrie2 branch 3 times, most recently from d740cd4 to 176c5ac Compare March 24, 2022 23:47
@RedDevilus
Copy link
Contributor Author

@Dreadmoth Yeah, I just removed trilinear as it's more a mess to deal with.

The game also needs round sprite half for the transitional areas and red forest because of vertical lines similar to Star Ocean 3.
+ other fixes, read the GameDB comments for more information.
Relevant games:
- Atelier Iris 3 - Grand Phantasm
- Baldur's Gate - Dark Alliance 1 / 2
- Call of Duty 2 - Big Red One
- Dark Cloud 1 / 2
- Mana Khemia 1 / 2
- Sims 2 - Castaway
- Valkyrie 2 - Silmeria
@refractionpcsx2
Copy link
Member

The Baldurs gate font issues are more upscaling problems, trilinear is like a very bad plaster to cure covid.

@refractionpcsx2 refractionpcsx2 merged commit 8485af6 into PCSX2:master Mar 25, 2022
@RedDevilus RedDevilus deleted the GameDB-Valkyrie2 branch March 25, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants