wxWidgets 3.0 fixes #741
Merged
wxWidgets 3.0 fixes #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom scroll event handler increments/decrements the slider value by one when a click event is detected. It also propagates the event to the wxWidgets3.0 built in slider scroll event handler, which repeats the same action. This causes the slider to add/subtract 2 whenever it is clicked on Windows. Remove the custom function.
The "Other Hacks" and "microVU Hacks" checkbox descriptions are truncated in both Windows and Linux. Use sizer flags so the descriptions show up properly.
Visual Studio flags wxCore30 as being out of date because it can't find the rcdefs.h header file. Use the arch dependent pathname so it is located correctly.
People prefer it that way and it's an easy enough fix.
wxWidgets 3.0 seems to have a different default device context alpha channel handling on Windows, which makes the screenshot function unusable. As a incomplete fix, remove the alpha channel information from the final image on Windows. Screenshots degrade slightly.
|
Thanks. I was just about to commit a patch which restores |
|
Well, that was my fault. I seem to suck at the whole build system business. :( |
|
You seem to be doing better than most ;) Thanks again! |
|
The EE slider starts from 1 because we run the EE by default lower than on the PS2, with no compatibility hit, IIRC. |
|
Ok, turns out I should read the text description more closely. Cyclerate of 0 would probably confuse people ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressions fixed:
Regressions partially fixed:
Other fixes:
Tested on Windows VS2013, Linux wx2.8/wx3.0.
Question: Why does the EE slider start from 1 and the VU slider start from 0? It makes no sense to me.