addressing PR comments

PDAL · May 27, 2020 · 4edc977 · 4edc977
1 parent abe3fe3
commit 4edc977
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/filters/LloydKMeansFilter.cpp b/filters/LloydKMeansFilter.cpp
@@ -49,6 +49,8 @@ static StaticPluginInfo const s_info{
 
 CREATE_STATIC_STAGE(LloydKMeansFilter, s_info)
 
+LloydKMeansFilter::LloydKMeansFilter() {}
+
 std::string LloydKMeansFilter::getName() const
 {
     return s_info.name;
@@ -100,10 +102,7 @@ void LloydKMeansFilter::filter(PointView& view)
     // additional dimensions as specified via filter options
     PointTable table;
     table.layout()->registerDims({Id::X, Id::Y, Id::Z});
-    for (auto const& dimid : m_dimIdList)
-    {
-        table.layout()->registerDim(dimid);
-    }
+    table.layout()->registerDims(m_dimIdList);
 
     // create view of initial cluster centers
     PointViewPtr centers(new PointView(table));
@@ -157,9 +156,9 @@ void LloydKMeansFilter::filter(PointView& view)
                 centers->setField(m_dimIdList[i], id, M1[i][id]);
             }
         }
+        centers->invalidateProducts();
+        centers->build3dIndex();
     }
-    centers->invalidateProducts();
-    centers->build3dIndex();
 }
 
 } // namespace pdal
diff --git a/filters/LloydKMeansFilter.hpp b/filters/LloydKMeansFilter.hpp
@@ -46,7 +46,8 @@ class ProgramArgs;
 class PDAL_DLL LloydKMeansFilter : public Filter
 {
 public:
-    LloydKMeansFilter() : Filter() {}
+    LloydKMeansFilter();
+
     LloydKMeansFilter& operator=(const LloydKMeansFilter&) = delete;
     LloydKMeansFilter(const LloydKMeansFilter&) = delete;
 

diff --git a/filters/private/Segmentation.cpp b/filters/private/Segmentation.cpp
@@ -296,7 +296,7 @@ PointIdList farthestPointSampling(PointView& view, point_count_t count)
         // Record the PointId of the farthest point and add it to the output
         // PointView.
         PointId idx(it - min_dists.begin());
-	ids[i] = idx;
+        ids[i] = idx;
 
         // Compute distances from idx to all other points.
         kdi.knnSearch(idx, view.size(), &indices, &sqr_dists);