Don't copy point refs.

PDAL · Jul 9, 2020 · b99583c · b99583c
1 parent 072229a
commit b99583c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/plugins/e57/io/E57Reader.cpp b/plugins/e57/io/E57Reader.cpp
@@ -327,10 +327,11 @@ bool E57Reader::fillPoint(PointRef& point)
 point_count_t E57Reader::read(PointViewPtr view, point_count_t count)
 {
     point_count_t numPoints = e57plugin::numPoints(*m_data3D);
+    PointRef point(*view);
     for (PointId counter = 0, nextId = view->size(); counter < numPoints;
             ++counter, ++nextId)
     {
-        PointRef point(view->point(nextId));
+        point.setPointId(nextId);
         fillPoint(point);
     }
 

diff --git a/plugins/e57/io/Scan.cpp b/plugins/e57/io/Scan.cpp
@@ -65,7 +65,7 @@ bool Scan::hasPose() const
     return m_hasPose;
 }
 
-void Scan::transformPoint(pdal::PointRef pt) const
+void Scan::transformPoint(pdal::PointRef& pt) const
 {
     auto x = pt.getFieldAs<double>(pdal::Dimension::Id::X);
     auto y = pt.getFieldAs<double>(pdal::Dimension::Id::Y);

diff --git a/plugins/e57/io/Scan.hpp b/plugins/e57/io/Scan.hpp
@@ -53,7 +53,7 @@ class PDAL_DLL Scan
     std::set<std::string> getDimensions() const;
     e57::CompressedVectorNode getPoints() const;
     bool hasPose() const;
-    void transformPoint(pdal::PointRef pt) const;
+    void transformPoint(pdal::PointRef& pt) const;
     pdal::BOX3D getBoundingBox() const;
     double rescale(pdal::Dimension::Id dim, double value);
     StructureNode getPointPrototype();