Fixed missed PUBLIC -> PRIVATE conversion in macros.cmake.

PDAL · May 7, 2018 · d9f49f2 · d9f49f2
1 parent ac13a00
commit d9f49f2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/cmake/macros.cmake b/cmake/macros.cmake
@@ -132,7 +132,7 @@ macro(PDAL_ADD_PLUGIN _name _type _shortname)
         ${PROJECT_BINARY_DIR}/include
         ${PDAL_INCLUDE_DIR})
     target_link_libraries(${${_name}}
-        PUBLIC
+        PRIVATE
             ${PDAL_BASE_LIB_NAME}
             ${PDAL_UTIL_LIB_NAME}
             ${PDAL_ADD_PLUGIN_LINK_WITH}

diff --git a/plugins/pgpointcloud/CMakeLists.txt b/plugins/pgpointcloud/CMakeLists.txt
@@ -54,7 +54,10 @@ if (BUILD_PGPOINTCLOUD_TESTS)
         FILES
             test/PgpointcloudWriterTest.cpp
         LINK_WITH
-            ${reader_libname} ${writer_libname})
+            ${reader_libname}
+            ${writer_libname}
+            ${POSTGRESQL_LIBRARIES}
+    )
     target_include_directories(pgpointcloudtest PRIVATE
         ${CMAKE_CURRENT_BINARY_DIR}/include)
 endif()
diff --git a/plugins/sqlite/CMakeLists.txt b/plugins/sqlite/CMakeLists.txt
@@ -36,8 +36,13 @@ target_include_directories(${writer_libname} PRIVATE ${LIBXML2_INCLUDE_DIR})
 #
 if(BUILD_SQLITE_TESTS)
 	PDAL_ADD_TEST(sqlitetest
-        FILES test/SQLiteTest.cpp
-        LINK_WITH ${reader_libname} ${writer_libname})
+        FILES
+            test/SQLiteTest.cpp
+        LINK_WITH
+            ${reader_libname}
+            ${writer_libname}
+            ${SQLITE3_LIBRARY}
+    )
     target_include_directories(sqlitetest PRIVATE
         ${PDAL_IO_DIR}
         ${LIBXML2_INCLUDE_DIR})