Skip to content

Commit

Permalink
Turn off normal refinement by default (#3134)
Browse files Browse the repository at this point in the history
  • Loading branch information
chambbj committed Jun 16, 2020
1 parent 50c08db commit e3a3395
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions doc/stages/filters.normal.rst
Expand Up @@ -36,13 +36,13 @@ normal flipping.
regardless of the always_up_ flag. To disable all normal flipping, do not
provide a viewpoint_ and set `always_up`_ to false.

In addition to always_up_ and viewpoint_, users can run a refinement step (on
In addition to always_up_ and viewpoint_, users can run a refinement step (off
by default) that propagates normals using a minimum spanning tree. The
propagated normals can lead to much more consistent results across the dataset.

.. note::

To disable normal propagation, users can set refine_ to `false`.
To enable normal propagation, users can set refine_ to `true`.

.. embed::

Expand Down Expand Up @@ -84,4 +84,4 @@ _`always_up`

_`refine`
A flag indicating whether or not to reorient normals using minimum spanning
tree propagation. [Default: true]
tree propagation. [Default: false]
2 changes: 1 addition & 1 deletion filters/NormalFilter.cpp
Expand Up @@ -90,7 +90,7 @@ void NormalFilter::addArgs(ProgramArgs& args)
m_args->m_up, true);
args.add("refine",
"Refine normals using minimum spanning tree propagation?",
m_args->m_refine, true);
m_args->m_refine, false);
}

void NormalFilter::addDimensions(PointLayoutPtr layout)
Expand Down

0 comments on commit e3a3395

Please sign in to comment.