Return an error code if no command is provided. (#3355)

Close #3354
PDAL · Feb 17, 2021 · ede0e8c · ede0e8c
1 parent 9be0a60
commit ede0e8c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/apps/pdal.cpp b/apps/pdal.cpp
@@ -323,7 +323,7 @@ int App::execute(StringList& cmdArgs, LogPtr& log)
     catch (arg_val_error const& e)
     {
         Utils::printError(e.what());
-        return -1;
+        return 1;
     }
 
     log = Log::makeLog("PDAL", m_log, m_logtiming);
@@ -371,8 +371,11 @@ int App::execute(StringList& cmdArgs, LogPtr& log)
             gdal::unregisterDrivers();
         }
         else
+        {
             log->get(LogLevel::Error) << "Command '" << m_command <<
                 "' not recognized" << std::endl << std::endl;
+            ret = 1;
+        }
         return ret;
     }
 
@@ -381,7 +384,7 @@ int App::execute(StringList& cmdArgs, LogPtr& log)
     if (cmdArgs.size())
     {
         Utils::printError("Unexpected argument '" + cmdArgs[0] + "'.");
-        return -1;
+        return 1;
     }
 
     if (m_showVersion)