Merge remote-tracking branch 'origin/master' into issue-2809

doc/development/writing-filter.rst

@@ -65,7 +65,13 @@ elements - the filter name, description, and a link to documentation.
 
 PDAL requires that filter names always begin with ``filters.``, and end with a
 string that uniquely identifies the filter. The description will be displayed
-to users of the PDAL CLI (``pdal --drivers``).
+to users of the PDAL CLI (``pdal --drivers``).  When making a shared plugin,
+the name of the shared library must correspond with the name of the filter
+provided here.  The name of the generated shared object must be
+
+::
+
+    libpdal_plugin_filters_<filter name>.<shared library extension>
 
 Next, we pass the following to the ``CREATE_SHARED_STAGE`` macro, passing in
 the name of the stage and the ``PluginInfo`` struct.

doc/development/writing-reader.rst

@@ -60,6 +60,14 @@ to the main PDAL installation.  The macro is supplied with the class name
 of the plugin and a PluginInfo object.  The PluginInfo objection includes
 the name of the plugin, a description, and a link to documentation.
 
+When making a shared plugin,
+the name of the shared library must correspond with the name of the reader
+provided here.  The name of the generated shared object must be
+
+::
+
+    libpdal_plugin_readers_<reader name>.<shared library extension>
+
 .. literalinclude:: ../../examples/writing-reader/MyReader.cpp
    :language: cpp
    :lines: 8-15

doc/development/writing-writer.rst

@@ -79,6 +79,13 @@ to create a SHARED stage, which means it will be external to the main PDAL
 installation.  When using the macro, we specify the name of the Stage and
 the PluginInfo struct we defined earlier.
 
+When making a shared plugin, the name of the shared library must
+correspond with the name of the writer
+provided here.  The name of the generated shared object must be
+
+::
+    libpdal_plugin_writers_<writer name>.<shared library extension>
+
 .. literalinclude:: ../../examples/writing-writer/MyWriter.cpp
    :language: cpp
    :lines: 20-31

filters/private/delaunator.hpp

@@ -12,7 +12,27 @@
 namespace delaunator {
 
 constexpr std::size_t INVALID_INDEX =
-    std::numeric_limits<std::size_t>::max();
+    (std::numeric_limits<std::size_t>::max)();
+
+class Point
+{
+public:
+    Point(double x, double y) : m_x(x), m_y(y)
+    {}
+    Point() : m_x(0), m_y(0)
+    {}
+
+
+    double x() const
+    { return m_x; }
+
+    double y() const
+    { return m_y; }
+
+private:
+    double m_x;
+    double m_y;
+};
 
 class Point
 {