do_offset_z in InPlaceReprojection

[pramsey]

It's not clear what do_offset_z does in InPlaceReprojection

https://github.com/PDAL/PDAL/blob/master/src/filters/InPlaceReprojection.cpp#L216

Contextually, I'd expect it to alter the offset value of the Z dimension, but the code seems to pass a pointer to the x offset value into the expected slot.

[hobu]

It should probably be renamed to "do_you_really_want_to_reproject_z_values_of_bboxen"

The z's for bboxes don't always reproject (infinity, or -0/+0, etc). This switch was in there so if you really did want to reproject the whole bbox, you could, but it defaults to just reprojecting x/y.

On Jun 24, 2013, at 2:54 PM, Paul Ramsey notifications@github.com wrote:

It's not clear what do_offset_z does in InPlaceReprojection

https://github.com/PDAL/PDAL/blob/master/src/filters/InPlaceReprojection.cpp#L216

Contextually, I'd expect it to alter the offset value of the Z dimension, but the code seems to pass a pointer to the x offset value into the expected slot.

—
Reply to this email directly or view it on GitHub.

[pramsey]

Does the code actually do it though? It pulls a reference to &offset_x (not z) and passes that into the reprojection.

[hobu]

Indeed. That's stinky.

On Jun 24, 2013, at 3:26 PM, Paul Ramsey notifications@github.com wrote:

Does the code actually do it though? It pulls a reference to &offset_x (not z) and passes that into the reprojection.

—
Reply to this email directly or view it on GitHub.