Simply the ChipperFilter code #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, you're not missing anything. When the code was first written, we provided the bounds for each "cell". This code would make sure the bounds were available when each cell was created. Now that we don't write the bounds, this code is superfluous. Thanks for catching. |
|
Thanks for the review and merging this. |
You've made me realize there's more unneeded code in the Chipper filter. I'll create a new PR with more clean-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChipperFilter code currently includes a
finalSplitfunction that calculates values (namelyleft1,left2,right1andright2) that are not used when emitting results. This PR removes thefinalSplitfunction and makes thesplitfunction itself do the emissions when there are two partitions left.Please tell me if I am missing something here.