Handle repeated options. #2021
Handle repeated options. #2021
Conversation
doc/pipeline.rst
Outdated
| Each of these output sets is called a point view. Point views are carried | ||
| through a PDAL pipeline individually. Some writers can produce separate | ||
| output for each input point view. These writers use a placeholder character | ||
| (#) in the output filename which is replaced by a incrementing integer for |
There was a problem hiding this comment.
Should read replaced by an incrementing integer.
There was a problem hiding this comment.
@abellgithub I think this mostly looks good. So, in limited testing, it looks like both comma-separated options and JSON arrays are allowed for multiple options. Probably the comma-separated stuff is stage specific (I've only tested with range filter). Is this the intended behavior? I don't mind, but I did notice that in the colorization example you explicitly change it from comma-separated repeated options to the array.
|
If an option is bound to vector<string>, it can be parsed by ProgramArgs as a comma-separated list. Theoretically, you can handle any argument type that takes a vector<type> as you like by adding appopriate code. But with this change you can let the JSON parser break the options up for you and then add them one at a time. There are a bunch of places where we take vector<string> as options, and these can be handled either way. I changed the colorization example just to provide an example using the syntax that's now supported. |
|
LGTM |
Close #1941