Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix classbits ctor and put classbits in a class #3068

Merged
merged 2 commits into from
May 15, 2020
Merged

Fix classbits ctor and put classbits in a class #3068

merged 2 commits into from
May 15, 2020

Conversation

abellgithub
Copy link
Contributor

Close #3066

@abellgithub
Use default classbits.
32ec195 
Create a class to deal with classbits.
@abellgithub
Remove confusing boolean cast of PointClasses.
d4d9389 
Make bits private.
@abellgithub abellgithub requested a review from chambbj May 14, 2020 16:54
chambbj
chambbj approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@chambbj chambbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement; thanks!

@abellgithub abellgithub merged commit 1a3215d into master May 15, 2020
@abellgithub abellgithub deleted the issue-3066 branch May 22, 2020 20:53
@dokempf dokempf mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chambbj chambbj chambbj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect default for SMRF classbits
2 participants
@abellgithub @chambbj