Improve check for packing quad values #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohawk2
approved these changes
Jan 28, 2022
zmughal
force-pushed
the
pack-Q-available
branch
from
5df3554
to
ae222e0
Compare
- Check if quad values can be packed by using `eval`. This is because
the condition for whether `pack` can use quad values is a bit more
complicated. See:
* <https://www.nntp.perl.org/group/perl.perl5.porters/2013/10/msg208380.html>,
* <Perl/perl5@1640b98>,
* <Perl/perl5@c174bf3>
- Add unsigned quad value (Q) to the condition.
- Also check for pack("D", ...) directly. This simplifies the check and
removes the need for checking against the Perl version.
zmughal
force-pushed
the
pack-Q-available
branch
from
ae222e0
to
5a7fcfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if quad values can be packed by using
eval. This is becausethe condition for whether
packcan use quad values is a bit morecomplicated. See:
Add unsigned quad value (Q) to the condition.