Updated Zork to address issue with bad message when opening non-functional windows #2257
Conversation
eswenson1
force-pushed
the
ejs/zork-20231118
branch
from
0ff861e
to
20b3267
Compare
eswenson1
force-pushed
the
ejs/zork-20231118
branch
from
20b3267
to
1b0454b
Compare
|
@larsbrinkhoff Can you approve? Looks like builds are happy with my new approach. @heasm66 I think I added you as a reviewer as well. |
|
Great, finally! It's strange that XXFILE (or something else) worked ok but not any more. I'll just split the commit in twain: one for Zork updates, and one for Tcl changes. |
Updated zork.tcl to no longer use XXFILE to either compile or load/save zork. XXFILE seems too brittle and doesn't function consistently.
Seems the occasional failures during zork build can be mitigated by breaking up some of the compiles into separate jobs.
Updated Zork to address issue with bad message when opening non-functional windows. Addresses this issue: heasm66/mdlzork#58 And this fix: heasm66/mdlzork#59
larsbrinkhoff
force-pushed
the
ejs/zork-20231118
branch
from
eb9df84
to
59156de
Compare
|
Three actually; the single commit has been split, but the end result is identical. Approved. A question: should the XXFILEs still be there as a convenience for building Zork manually? |
I think so. I use them to build on ITS. Too cumbersome to be done manually. |
Yeah. The XXFILE approach works fine for me on ES and EX, as long as I’m not running them from expect. No clue why that is the case. Actually sometimes it runs under expect too — but not always. |
When you attempt to "open window" in the North and South of House, you get a response that isn't appropriate. With this fix, you get "This window cannot be opened.".
Addresses this issue: heasm66/mdlzork#58
And this fix: heasm66/mdlzork#59
https://github.com/AlexProudfoot