Changes to enable HVAC app to change controls in car using AMB13 and its new Crosswalk API. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on platform. Use cases all pass for at-desk operation. Signed-off-by: Jeff Eastwood <jeastwo1@jaguarlandrover.com> Change-Id: Ic3b0c76997d85ca45d7c4077907da6d1596da929
Fixing build process
Change-Id: I519d68f402f96a2b2553257f795c955263a90a59
…its new Crosswalk API. Change-Id: I035c22559dcdc8a457318b1b47e48d14e80f0cbf Signed-off-by: Jeff Eastwood <jeastwo1@jaguarlandrover.com>
aeichepdx
added a commit
that referenced
this pull request
May 7, 2015
Changes to enable HVAC app to change controls in car using AMB13 and its new Crosswalk API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code review, compare with previous commit 4661c21
These changes fix the Makefile so that the feb1.install target works, and corrects the pkgcmd -u command so that it actually uninstalls the previous app.
Depends on my latest commit to common-app; if that has not been merged into GitHub yet, please pull that commit and test against it.
Testing: at your desk, you can confirm that HVAC looks the same (aside from lack of top and bottom bars, which is a regression caused elsewhere.)
To test that controls on the UI actually change AMB properties, install HVAC onto 192.168.6.11 and come grab me and I'll show you how to do that verification.