Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for running Meteor in a configured directory #29

Merged
merged 3 commits into from
Apr 14, 2015

Conversation

johnschult
Copy link
Contributor

Summary

When using something like Iron Meteor or when a developer has their Meteor app in a subdirectory under the project path, it was not possible to run Meteor. I added a configuration setting to allow starting Meteor in a directory other than the current working directory.

The Atom configuration supports using ordering and titles so I ordered the configuration and added titles to fix things like Mongo Oplog U R L.

Change Description

  • Added the meteorAppPath configuration setting (fb3e3ec).
  • Ordered the configuration items (e6c3318).
  • Some of the configuration items benefited from a better description and title (f7c8667).

John Schult added 3 commits March 5, 2015 07:28
Implemented a configuration setting to allow for starting Meteor in a
different directory other than the current working directory. For
example, “app”, etc…
@johnschult johnschult changed the title Support for running Meteor in configured directory Support for running Meteor in a configured directory Mar 5, 2015
@johnschult
Copy link
Contributor Author

After implementing this I realized that as the settings are not project specific, setting meteorAppPath for running meteor-helper in one project would not work in another project that has the Meteor application in the root directory.

This seems to be a common request and possibly on the 1.0 roadmap.

@PEM--
Copy link
Owner

PEM-- commented Mar 5, 2015

Still, that's interesting and helpful. For tackling multiple instances, I rely on mup.json. There could be something to do for enhancing this to handle sub directories.

I'm in plain middle of a massive Saltstack configuration for easing Meteor deployment on bare metal, Docker and so forth. Once done, I think I should be able to integrate some best practices in Atom. Will see.

@dotnetwise
Copy link

+1

PEM-- added a commit that referenced this pull request Apr 14, 2015
Support for running Meteor in a configured directory
@PEM-- PEM-- merged commit 7c765ef into PEM--:master Apr 14, 2015
@PEM--
Copy link
Owner

PEM-- commented Apr 14, 2015

I've merged it as well as the #33. Thanks.

It should work with multiple instances of Atom since I don't use the reactive nature of the settings. Thus, we are able to setup multiple instances of Atom on different apps 😉

It's available in the 0.24.0.

@johnschult
Copy link
Contributor Author

Sweet 👍🏻

++john

On Apr 14, 2015, at 3:03 PM, Pierre-Eric Marchandet notifications@github.com wrote:

I've merged it as well as the #33. Thanks.

It should work with multiple instances of Atom since I don't use the reactive nature of the settings. Thus, we are able to setup multiple instances of Atom on different apps

It's available in the 0.24.0.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants