ALPHA7 #82
Closed
ALPHA7 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robske110
suggested changes
Aug 24, 2017
| /** | ||
| * @return HereAuth | ||
| */ | ||
| public function getMain(){ |
There was a problem hiding this comment.
Why did you remove the type hint?
There was a problem hiding this comment.
Sorry i fixed this a little bit ago, but the branch i was using was the pw-hash branch so i tried pushing it onto this, ima restart
| @@ -144,7 +144,7 @@ private function getHelpMessage(User $user){ | |||
| $output = "Your HereAuth options:\n"; | |||
| $mlp = $opts->maskLocPos; | |||
| if(!preg_match(/** @lang RegExp */ | |||
| '#^((\?spawn\?)|((-)?[0-9]+,(-)?[0-9]+,(-)?[0-9]+))@([^/\\\\]+)$#', $mlp, $match) | |||
| '#^((\?spawn\?)|((\-)?[0-9]+,(\-)?[0-9]+,(\-)?[0-9]+))@([^/\\\\]+)$#', $mlp, $match) | |||
There was a problem hiding this comment.
It is actually the same, just more explicit, but unnecessary.
| @@ -47,7 +47,7 @@ public function run(array $args, CommandSender $sender){ | |||
| // $this->getMain()->getDataBase()->saveData($info, false); | |||
| // return "Account $args[0] is changed to $args[1]"; | |||
| // } | |||
| $this->getMain()->getDataBase()->renameAccount($args[0], $args[1], function($result) use ($args, $sender){ | |||
| $this->getMain()->getDataBase()->renameAccount($args[0], $args[1], function ($result) use ($args, $sender){ | |||
| @@ -36,11 +36,11 @@ protected function run(array $args, CommandSender $sender){ | |||
| return $ev->getCancelMessage(); | |||
| } | |||
| if($user !== null){ | |||
| $user->resetAccount(function($success) use ($sender, $name){ | |||
| $user->resetAccount(function ($success) use ($sender, $name){ | |||
| $sender->sendMessage($success ? "Account $name has been unregistered." : "Account $name does not exist."); | ||
| }); | ||
| }else{ | ||
| $this->getMain()->getDataBase()->unregisterAccount($name, function($success) use ($sender, $name){ | ||
| $this->getMain()->getDataBase()->unregisterAccount($name, function ($success) use ($sender, $name){ |
| /** | ||
| * @return HereAuth | ||
| */ | ||
| public function getMain(){ |
There was a problem hiding this comment.
This change is entirely unnecessary.
SOF3
requested changes
Aug 24, 2017
| return $this->main; | ||
| } | ||
|
|
||
| public final function execute(CommandSender $sender, $commandLabel, array $args){ |
There was a problem hiding this comment.
Why remove the final modifier?
| @@ -47,7 +47,7 @@ public function run(array $args, CommandSender $sender){ | |||
| // $this->getMain()->getDataBase()->saveData($info, false); | |||
| // return "Account $args[0] is changed to $args[1]"; | |||
| // } | |||
| $this->getMain()->getDataBase()->renameAccount($args[0], $args[1], function($result) use ($args, $sender){ | |||
| $this->getMain()->getDataBase()->renameAccount($args[0], $args[1], function ($result) use ($args, $sender){ | |||
| /** | ||
| * @return HereAuth | ||
| */ | ||
| public function getMain(){ |
There was a problem hiding this comment.
Why did you remove the type hint?
| /** | ||
| * @return HereAuth | ||
| */ | ||
| public function getMain(){ |
There was a problem hiding this comment.
This change is entirely unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
ALPHA7
Relevant issues
ALPHA7
Changes (ABC)
API changes
Behavioural changes
Configuration changes
Backwards compatibility
Follow-up
Tests