Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constant species in condition table #65

Closed
dweindl opened this issue Feb 18, 2019 · 2 comments
Closed

Allow constant species in condition table #65

dweindl opened this issue Feb 18, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dweindl
Copy link
Member

dweindl commented Feb 18, 2019

At the moment we do not allow constant species in the condition table. To have these concentrations condition-specific, the current way to go would be to turn those species into parameters. For the simulation this is fine.

However, this takes away the possibility of listing those species as reaction modifiers, which makes sense in terms of underlying biology and for model visualization. Furthermore, keeping those species as SBML species would allow for better annotation.

What was the motivation for not allowing constant species in the condition table?

@dweindl dweindl added question Further information is requested enhancement New feature or request and removed question Further information is requested labels Feb 18, 2019
@dweindl
Copy link
Member Author

dweindl commented Feb 21, 2019

As agreed during today's discussion, this will be supported.

TODO:

  • Update documentation
  • Adapt linter code
  • ?

@dweindl dweindl changed the title Allow constant species in condition table? Allow constant species in condition table Feb 21, 2019
@dweindl dweindl self-assigned this Feb 21, 2019
dweindl added a commit that referenced this issue Feb 21, 2019
Update doc for now allowed constant species in condition table (#65)
@dweindl
Copy link
Member Author

dweindl commented Apr 5, 2019

Done.

@dweindl dweindl closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant