fix simulate #479
Merged
fix simulate #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 78.03% 78.00% -0.04%
==========================================
Files 23 23
Lines 2295 2300 +5
Branches 544 546 +2
==========================================
+ Hits 1791 1794 +3
- Misses 369 370 +1
- Partials 135 136 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
dweindl
approved these changes
Nov 8, 2020
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
dweindl
added a commit
that referenced
this pull request
Jan 11, 2021
Default noise distribution wasn't handled in some cases Add option to ensure synthetic data is non-negative (can become negative after noise is added) * fix default noise distribution * switch to pandas isna * Return negative values by default. * change non-negative argument to zero-bounded * docs, set random seed Co-authored-by: dilpath <59329744+dilpath@users.noreply.github.com> Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
jvanhoefer
added a commit
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
ensure synthetic data file rows are ordered as in the measurements file