Specification of math expressions #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
May 21, 2024
Related to PEtab-dev/PEtab#579 * ANTLR grammar for PEtab math expressions + derived lexer/parser/visitor * Test cases * PEtab -> SymPy converter
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
May 22, 2024
Related to PEtab-dev/PEtab#579 * ANTLR grammar for PEtab math expressions + derived lexer/parser/visitor * Test cases * PEtab -> SymPy converter
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
dweindl
commented
May 30, 2024
dilpath
reviewed
May 30, 2024
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
sebapersson
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
I am happy with all proposed changes, and think that the current syntax encapsulates the relevant functions.
As a potential addition, in the test-cases I just think three tests on Boolean <-> float conversion could be added (when everyone agree on that point).
|
I'm happy with the proposed description. If anything I'd rename the |
dweindl
added a commit
to PEtab-dev/petab_test_suite
that referenced
this pull request
Jun 26, 2024
dweindl
changed the title
dweindl
added a commit
to PEtab-dev/libpetab-python
that referenced
this pull request
Jun 26, 2024
Related to PEtab-dev/PEtab#579 * ANTLR grammar for PEtab math expressions + derived lexer/parser/visitor * Test cases * PEtab -> SymPy converter Note: All sympy symbols in PEtab match expressions now have `real=True`.
dweindl
added a commit
to PEtab-dev/petab_test_suite
that referenced
this pull request
Jul 1, 2024
Add math expression test cases. Related to PEtab-dev/PEtab#579
dweindl
added a commit
that referenced
this pull request
Jul 3, 2024
Previously, the math expression syntax wasn't specified. This was very problematic, because different libraries and programming languages have different names for the same functions, and more importantly, differ in operator precedence. Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com> Co-authored-by: dilpath <dilan.private+github@outlook.com>
dweindl
added a commit
that referenced
this pull request
Jul 3, 2024
Previously, the math expression syntax wasn't specified. This was very problematic, because different libraries and programming languages have different names for the same functions, and more importantly, differ in operator precedence. Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com> Co-authored-by: dilpath <dilan.private+github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the math expression syntax wasn't specified. This was very problematic, because different libraries and programming languages have different names for the same functions, and more importantly, differ in operator precedence.
👀 https://petab--579.org.readthedocs.build/en/579/documentation_data_format.html#math-expressions-syntax
Examples / test cases: https://github.com/dweindl/libpetab-python/blob/parse_math/tests/math/math_tests.yaml