Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert_model_parameters_in_condition_or_parameter_table (#43) #62

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 18, 2019

Model non-placeholder model parameters must be either specified in the or parameter table, unless they are AssignmentRule target, in which case they must not occur in either. that.

Model non-placeholder model parameters must be either specified in the
    condition or parameter table, unless they are AssignmentRule target, in
    which case they must not occur in either.
    Check that.
@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #62 into develop will increase coverage by 0.28%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
+ Coverage    59.48%   59.76%   +0.28%     
===========================================
  Files            5        5              
  Lines          580      604      +24     
  Branches       120      127       +7     
===========================================
+ Hits           345      361      +16     
- Misses         212      219       +7     
- Partials        23       24       +1
Impacted Files Coverage Δ
petab/lint.py 41.17% <66.66%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f7fa4...2ec38e2. Read the comment docs.

@dweindl dweindl merged commit 3a84e84 into develop Feb 18, 2019
@dweindl dweindl deleted the feature_check_model_params_in_table branch February 18, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants