add costs #80
Merged
add costs #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #80 +/- ##
===========================================
- Coverage 60.03% 59.08% -0.95%
===========================================
Files 5 5
Lines 603 633 +30
Branches 128 137 +9
===========================================
+ Hits 362 374 +12
- Misses 217 231 +14
- Partials 24 28 +4
Continue to review full report at Codecov.
|
dweindl
approved these changes
Mar 20, 2019
petab/core.py
Outdated
|
|
||
| # read noise distributions from measurement file | ||
|
|
||
| grouping_cols = [col for col in |
There was a problem hiding this comment.
Need to check for all-NaN, otherwise grouping will fail
petab/lint.py
Outdated
| @@ -220,6 +219,7 @@ def measurement_table_has_timepoint_specific_mappings(measurement_df): | |||
| grouped_df2 = grouped_df.groupby(grouping_cols).size().reset_index() | |||
|
|
|||
| if len(grouped_df.index) != len(grouped_df2.index): | |||
| logger.warn(grouped_df) | |||
There was a problem hiding this comment.
This should come with a message, not?
| Check whether there are not multiple noise distributions for an | ||
| observable, and that the names are correct. | ||
| """ | ||
| df = measurement_df.copy() |
There was a problem hiding this comment.
Should also check for valid values, not only for uniqueness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.