Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve pandas 'chained' assignments problem in generate_experiment_id (Closes #91) #97

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

DantongWang
Copy link
Contributor

as described in the commit :)

@DantongWang DantongWang requested a review from dweindl April 8, 2019 11:33
@codecov-io
Copy link

codecov-io commented Apr 8, 2019

Codecov Report

Merging #97 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #97   +/-   ##
========================================
  Coverage    57.51%   57.51%           
========================================
  Files            7        7           
  Lines          758      758           
  Branches       167      167           
========================================
  Hits           436      436           
  Misses         293      293           
  Partials        29       29
Impacted Files Coverage Δ
petab/generate_experiment_id.py 87.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334074f...1b98c09. Read the comment docs.

@dweindl dweindl merged commit d8ebcb8 into develop Apr 8, 2019
@dweindl dweindl deleted the visualization branch April 8, 2019 11:36
@dweindl dweindl changed the title solve pandas 'chained' assignments problem in generate_experiment_id solve pandas 'chained' assignments problem in generate_experiment_id (Closes #91) Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants