Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vis: Make line plot markers configurable #254

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 16, 2024

Allow changing the default line style and markers for line plots.

(I'd also prefer to change the default to points-only (no line) for the measurements, but that's up for discussion.)

Allow changing the default line style and markers for line plots.

(I'd also prefer to change the default to points-only (no line) for the measurements, but that's up for discussion.)
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (aa8cd78) to head (3571743).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    76.24%   76.25%   +0.01%     
===========================================
  Files           34       34              
  Lines         3216     3218       +2     
  Branches       780      780              
===========================================
+ Hits          2452     2454       +2     
  Misses         560      560              
  Partials       204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl requested a review from dilpath April 16, 2024 12:56
@dweindl dweindl marked this pull request as ready for review April 16, 2024 12:56
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me as-is. Alternatively, make it a dict like

petab.visualize.plotter.measurement_style = {
    linestyle: "-.",
    marker: "x",
}

then parse plot-specific options like

plot_kwargs = plot_specific_defaults | petab.visualize.plotter.measurement_style

since then users can specify more plot options like markersize.

@dilpath
Copy link
Member

dilpath commented Apr 16, 2024

(I'd also prefer to change the default to points-only (no line) for the measurements, but that's up for discussion.)

Also my preference 👍

@dweindl dweindl merged commit f32feed into develop Apr 16, 2024
7 checks passed
@dweindl dweindl deleted the vis_lineplot_style branch April 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants