-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www-client/ungoogled-chromium: 109.0.5414.74: crashes on load #197
Comments
Mine is still building and I'm afraid that's too little information to work with. |
I've already rolled back. When the next version comes out I'll build that and see if it's still happening. (Accidentally closed this, reopen if you want) |
What are your use flags? |
USE="X clang convert-dict cups custom-cflags hevc js-type-check official optimize-thinlto optimize-webui pgo proprietary-codecs pulseaudio qt5 system-av1 system-ffmpeg system-harfbuzz system-icu system-jsoncpp system-libevent system-libusb system-openh264 system-openjpeg system-png system-re2 system-snappy thinlto vaapi -cfi -debug -enable-driver -gtk4 -hangouts -headless -kerberos -pic -screencast (-selinux) -suid -system-libvpx -vdpau -wayland -widevine" I doubt it has anything to do with flags. You'd better look into dmesg for any segfaults or anything suspicious. |
Our use flags are almost identical. It gave me some goodies this time in dmesg.
|
Have you tried starting with the empty profile? Have you tried googling your issue? Quick googling shows me some potentially related issues, but I cannot tell, how applicable they are to your case. If all that fails I would suggest getting the full back-trace from the crash and then analyzing what could cause it. Since 74 goes into stable, I'll reopen this issue. Maybe someone else also encounters this and / or could help further. |
I've been building this for a while now and occasionally I have one that won't build or run correctly. If I wait a release or two it will just resolve itself. As far as googling related issues, what I have found doesn't seem to apply to me. |
i got it too.
|
Guys, I don't have even a slightest idea, why this may happen. GDB should help. You might need to rebuild it with debug info for this to work. |
Any clues? |
Might as well throw my error on.
|
I'm getting what appears to be the same error:
(exact same error repeated dozens of times) Here's the very weird part: I also get the same error when rebuilding 108.0.5359.124_p1 with my current system! But if I restore 108.0.5359.124_p1 using the binary package I fortunately remembered to build, it works fine!! I did switch to a new machine since the last time I built 108 (old Haswell-E 5930k, now it's a Zen 4 7950x, I just swapped in my SSD). However, I don't think that's the issue because the old build works fine, and building using I did almost get it to work by buliding with libc++ (I needed to use I've tried downgrading llvm/clang from 15.0.7 to 15.0.6 (the last version I built successfully with). When building with libstdc++, I downgraded gcc to the earlier snapshot I was using for the last successful build. No luck with any of that. For those who are (and aren't) getting the error - are you using libc++ or libstdc++? On a related note, is it possible to build chromium with libc++ without using it systemwide? I did the hack to use |
I use libc++. |
Have you tried disabling all system-* dependencies? Maybe that could help? PS: I've also taken some changes from Gentoo, namely: new gcc patchset. This might also help. |
I wasn't able to build UGC with |
For what its worth I've been hitting the same crash with electron 21 and 22, I changed a lot of useflags on my system so it'll be tough to nail down. Could be recent clang/llvm issues, I'll try dropping all the system-* out next. Update: building with -system-* didn't help and -system-av1 is broken on electron-22, looks like it was missing something being bundled. |
building with |
I'm still getting the same error with 108.0.5359.124_p1. I did try building with full debug info with both libc++ (use_custom_libcxx=true) and libstdc++ - and the crash stack trace was exactly the same for both, and ends in unique_ptr. So I don't think the C++ library is the issue. I also disabled the Has anyone tried rebuilding 108 with a recent toolchain? I haven't actually tried 109 since my first attempt, since I wanted to make sure I could build a known-working version first. I'm probably going to try building with gcc next. |
OK, 108 works fine when built with gcc (and libstdc++, which is what I normally use). I did have to apply this patch to get it to build: https://chromium-review.googlesource.com/c/chromium/src/+/3963839 So obviously something has broken the clang build - and it must be a recent change in Gentoo packages. I'm out of ideas, though. I guess I can just build with gcc for now, although I'd prefer to have thinlto/pgo. |
Full back-trace might give some clues! Oh, BTW, I see you're using gcc-12! That might be the problem! I'm still with gcc-11. Others, do you also have gcc-12? |
gcc version 12.2.1 20221231 (Gentoo 12.2.1_p20221231 p8) |
I'm using gcc-12 as well (latest 12.2.1 snapshot). I'll try installing gcc-11 and rebuilding with clang. The build with gcc-12 actually did work, but maybe there's something in libstdc++ or some other gcc library/header that's breaking things when built with clang. Here's the backtrace, for the libstdc++ version. The libc++ version is identical except for the different STL header locations.
|
I'm leaning towards some weird incompatibility between either of: 1) libstdc++ from gcc-12; 2) chromium internals; 3) clang's libc++, all of which might be in play here. Also I recall this happened in the past at least once before… Looking forward for @thubble's rebuild with gcc-11. |
gcc-11 made no difference. I'm out of ideas :( |
Share the stacktrace you get in terminal. |
I, too, was experiencing this problem; I |
Looks like this was my issue as well. I commented out Excellent find, thanks! |
i have |
Does it work? Mine crashes just after start :) |
it works for me fine. but i'm not sure why. maybe the code is not triggered as i use proxy, or i evaded the buggy code by using more system libs instead of the bundled ones. |
I'm asking because 110 has yet another issue with libstdc++. But if ebuild works for you, this should mean that one of my local patches is to blame for me. |
yeah, it compiles and works fine for me, at least as fine as the version before. no custom patches applied here. |
Removing -fstack-clash-protection fixed it for me with 110.0.5481.77_p1 Sneaky gentoo. |
My way. |
This is essentially the same as saying that using GCC "fixes" the problem. The problematic line has already been identified above. |
I wonder why my systems never got that flag in hardened.cfg? |
Do you recall if you ever did |
Nope. Maybe I just didn't update clang for long enough for this to never happen to me :) |
Are we tracking multiple issues here? The removal of -fstack-clash-protection seems to fix a different chromium crash that happens later than initial start. Maybe since electron is building with chromium 108 it doesn't help. I still see the immediate crash/segfault on electron even after commenting that flag and rebuilding clang/llvm and then electron. It is not possible to build electron with gcc (at least not with gcc12). |
I think that's possible and it'd explain the inconsistent results, backtraces, and observations in the thread. It's probably worth chalking this bug up to |
@joecool1029, try to rebuild nodejs too. |
Already did as suggested, no change. Pretty sure we're looking at chromium fixing part of the problem in later versions combined with also needing this flag removed. |
I re-built qtwebengine (latest 5.15 git, Chromium 87-based with security backports) and re-enabled my clang/thinlto and It was really frustrating that this happened at exactly the time I upgraded to a completely new architecture, and was also experimenting with overclocking/undervolting - so thanks everyone for the help getting this sorted out! I don't build Electron from source, and I always build nodejs with gcc, so unfortunately I'm not sure what the problems are there. |
@joecool1029 Do you use chromium on your system? Does it compile and work? Do you remember if you did build 108 chromium, did it work? If electron crashes for you, so should chromium. |
No, I have edge as a backup but I use firefox as my browser. I think next attempt I'll drop all the system useflags in case dependencies were built with bad clang flags. Electron forces some of the GN flags so I can't test as many configs with it as plain chromium (like changing allocator). |
I am getting the same thing here. Currently doing a full debug build now, that will take a few hours. Will post results here later. Due to using packages, I have a local binary fallback of the previous version to use when I need too. I have mostly switch over to librewolf now. |
An update. Building a debug build with clang took 6+ hours. Sadly, can not load the debug build in gdb due to requiring over 32G of RAM. Building a debug build with gcc also required over 32G of RAM. I have only 32G of RAM. Building a normal build with USE="-clang" took 3+ hours and fixed the crashing problem for me. |
@Techwolf Can you post your |
I'll close this issue since the culprit was identified. @joecool1029 feel free to open separate issue regarding electron if you're willing to investigate it further. |
Sounds good, I'll start to look into the electron issue some more this week. |
On load the browser window comes up as crashed, continuously tries to reload in the background and never succeeds.
current build flags
The text was updated successfully, but these errors were encountered: