添加一个基础的变量追踪机制 #54
Closed
添加一个基础的变量追踪机制 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
reviewed
May 23, 2023
src/paddlefx/translator.py
Outdated
| args: list[VariableBase], | ||
| kwargs: dict[str, VariableBase], | ||
| ): | ||
| assert isinstance(fn, CallableVariable | ObjectVariable) |
There was a problem hiding this comment.
这个我记得 Python 3.10 才能用的吧，而且 Python 3.10 下性能远低于原来的写法，建议至少 3.11 再用（虽然还是慢……）
commit f5faff6 Author: Allen Guo <guosonglin001@gmail.com> Date: Sat Jun 10 15:02:16 2023 +0800 add PyCodegen demo (PFCCLab#57) commit 4e1f6ee Author: co63oc <co63oc@users.noreply.github.com> Date: Sun May 28 14:51:07 2023 +0800 fix a typo in interpreter.cc (PFCCLab#55) commit 4caa871 Author: co63oc <co63oc@users.noreply.github.com> Date: Sun May 28 14:50:29 2023 +0800 fix a typo in fx_profiling.py (PFCCLab#56)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提供了一个 任务三 中提到的类 VariableTracker 机制的一个基础版。