Update feature for Kong 0.10.x #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesslucifer
commented
Aug 3, 2017
lesslucifer
commented
- Upstreams & target management
- SNI & Certificate management
PGBI
requested changes
Aug 3, 2017
| </p> | ||
|
|
||
| <p class="white-text"> | ||
| ... |
| </p> | ||
|
|
||
| <p class="white-text"> | ||
| ... |
| </p> | ||
|
|
||
| <p class="white-text"> | ||
| ... |
| </p> | ||
|
|
||
| <p class="white-text"> | ||
| ... |
| <a class="btn-floating waves-effect waves-light" href="#/upstreams/{{upstream.id}}"> | ||
| <i class="material-icons">mode_edit</i> | ||
| </a> | ||
| <a class="btn-floating waves-effect waves-light blue modal-trigger" href="#/upstreams/{{upstream.id}}/targets"> |
There was a problem hiding this comment.
When clicking here, I get a "Not found error"
| ... | ||
| </p> | ||
| <p class="white-text"> | ||
| Checkout <a href="https://getkong.org/docs/admin-api/#add-upstream" target="_blank">Kong documentation</a> for the meaning of these parameters. |
There was a problem hiding this comment.
This page doesn't exist on getkong.org
| }] | ||
| } | ||
| }) | ||
| .when('/certificates', { |
There was a problem hiding this comment.
When browsing this page, I got a blank page.
| <app-field-error error="error.name"></app-field-error> | ||
| </div> | ||
| <div class="input-field col s12"> | ||
| <input id="ssl_certificate_id" ng-model="sni.ssl_certificate_id" type="text" class="validate" ng-class="{invalid: error.ssl_certificate_id}"> |
| <td>{{sni.name}}</td> | ||
| <td>{{sni.created_at | date}}</td> | ||
| <td class="right"> | ||
| <a class="btn-floating waves-effect waves-light" href="#/snis/{{sni.id}}"> |
There was a problem hiding this comment.
After creating an SNI, clicking this link would bring me back to /snis. So I'm unable to edit an SNI.
| <i class="material-icons">add</i> | ||
| </a> | ||
|
|
||
| <h3 class="header">snis</h3> |
* change targets get PATH
|
Certificates and SNIs support brought by #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.