Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to manage SNIs & Certificates #127

Merged
merged 4 commits into from
Oct 5, 2017
Merged

Add capability to manage SNIs & Certificates #127

merged 4 commits into from
Oct 5, 2017

Conversation

marcel-dias
Copy link
Contributor

Add capability to manage SNIs & Certificates

@PGBI
Copy link
Owner

PGBI commented Oct 4, 2017

Thanks @marceldiass for this contribution!

I found a few glitches:

When creating a new certificate:

I'm offered to choose the primary ID. Which Kong doesn't allow.
capture d ecran 2017-10-04 a 10 23 46

When creating a new sni:

Although I have already created certificates, I can't select them. The select input is empty:
capture d ecran 2017-10-04 a 10 26 03

Side note: is there a need anyway to have a form to create an SNI? If I'm not wrong, one can create an SNI by simply adding a new hostname to a certificate.

});
};

$scope.searchSnis = function() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any search box in the SNI index page. I believe this is dead code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed it

@marcel-dias
Copy link
Contributor Author

Nice catch..

Sending modifications:

  • Hide Certificate ID when creating a new certificate.

  • The SNI form was the way I've found to add more SNI to an existing Certificate.

    • I've tried to use the PUT and PATCH /certificates Kong API but it did nor recognize the snis field.

Please could you review the controller/sni.js code. Because I'm not able to reproduce the error in the SNI form. The Certificates list are always filled here.

@PGBI PGBI merged commit 12941f1 into PGBI:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants