Add kong 1.0.x support #199
Conversation
README.md
Outdated
| @@ -17,7 +17,8 @@ and services such as requests routing, authentication, rate limiting, etc. | |||
| | 3.0.x | >= 0.9, <0.12 | >= 6.0.0 | | |||
| | 3.1.x, 3.2.x | >= 0.9, <0.13 | >= 6.0.0 | | |||
| | 3.3.x, 3.4.x | >= 0.9, <0.14 | >= 6.0.0 | | |||
| | 3.5.x | >= 0.9, <0.15 | >= 6.0.0 | | |||
| | 3.5.x | >= 0.9, <0.15 | >= 6.0.0 | | |||
| | 3.6.x | >= 0.9, <1.1.x | >= 6.0.0 | | |||
There was a problem hiding this comment.
@illyaMs First of all, thanks for this great work. And sorry for taking so time to respond...
I believe Kong is following semver, so it should be safe to assume that the next version of Kong dashboard that you produced will be compatible with Kong < 2.0.0 and not just < 1.1.0.
Also, I was considering making it a major Kong-dashboard release (4.0.0) and dropping support for Kong < 1.0. The codebase, is becoming more and more difficult to read, especially tests. Now that Kong should be stable, I think it's time to stop supporting the 0.x versions. What do you think?
There was a problem hiding this comment.
@PGBI , no problem, nice to see you're still here 👍
Agree, I will change the 1.1.0 hardcodes to 2.0.0 everywhere and commit right now.
Speaking of dropping the pre-1.0.x support - I can only completely agree. Was thinking of it each time while adding one more hard-coded version check in tests, but obviously wasn't able to make this decision on my own :)
Maybe we can leave the >= 0.9, <2.0.0 support for v3.6.0 (to deliver existing work done with minimal effort and unblock the community to use the dashboard right away)? And agree to have a next 4.0.0 release with a major cleanup (so me or anyone else who's capable to commit on that part in the nearest future may have their time to work on that)?
There was a problem hiding this comment.
sounds good to me. Will do the merge and release this weekend. Thanks for your patience.
There was a problem hiding this comment.
I installed kong1.0.3 and this dashboard 3.6.0. The left menu are OK. But the comsumer's oauth2 plugin still not work well. The return url could not be set.
There was a problem hiding this comment.
I installed kong1.0.3 and this dashboard 3.6.0. The left menu are OK. But the comsumer's oauth2 plugin still not work well. The return url could not be set.
Some of the plugins were tested for compatibility, but I don't remember exactly if the oauth2 one was on the list. I think there were some Unit Tests covering it, so actually I think it should work.
Could you provide more details (ideally in separate github issue, linked to this MR/issue)?
|
hi,when can i use it? |
|
@PGBI When this will get merged? |
|
Hi, |
Actually |
|
Hi i tried the kong 1.0.0 and dashboard 3.6.0 ,3.4.0,3.5.0 but the dashboard are not supported for the kong 1.0.0 please check below logs in my terminal and suggest me where i am going wrong.And please share correct version of kong an dashboard supported.And also check the image attached of kong dashboard which is not showing API tab. pc@nilesh-PC MINGW64 /c/Program Files/Docker Toolbox pc@nilesh-PC MINGW64 /c/Program Files/Docker Toolbox pc@nilesh-PC MINGW64 /c/Program Files/Docker Toolbox pc@nilesh-PC MINGW64 /c/Program Files/Docker Toolbox |
|
Speaking of Speaking of @PGBI could you also please add the |
This PR adds kong 1.0.x support (and 0.15 as well, since it's a pre-release for 1.0.0 with most of the breaking changes already on board).
Changes include:
Fixed the tests as well, at least it's a green street for 1.0.x, 0.15 and 0.14 versions.
(Did my best to keep backward compatibility with elder versions, but that's not guaranteed).
Note: certificate tests are disabled when running Kong >= 0.15. Seems like kong has an improved cert/key params validation, which I wasn't able to overcome, unfortunately. Hope someone else will get more luck with that part.